Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the selection of the dynamic port in the Go sdk. #1127

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Simplify the selection of the dynamic port in the Go sdk. #1127

merged 1 commit into from
Oct 21, 2019

Conversation

roberthbailey
Copy link
Member

@roberthbailey roberthbailey commented Oct 21, 2019 •
edited
Loading

This brings the Go SDK in line with the C++ / Unity / Rust SDKs.

Part of #851.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6805be28-bb26-465d-88f6-face2fc9f51d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1127/head:pr_1127 && git checkout pr_1127
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-550cdf7

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 06ad244f-61e7-4aae-b1f1-8e6621344aa2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1127/head:pr_1127 && git checkout pr_1127
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-bad024f

@roberthbailey roberthbailey merged commit 1071930 into googleforgames:master Oct 21, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Oct 22, 2019
@roberthbailey roberthbailey deleted the go-sdk-dynamic-port branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@jkowalski jkowalski Awaiting requested review from jkowalski

Assignees

@pooneh-m pooneh-m

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones size/M
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@roberthbailey @agones-bot @google-oss-robot @pooneh-m @markmandel