Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteFunc could recieve a DeletedFinalStateUnknown #113

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

markmandel
Copy link
Member

It's possibel the DeleteFunc could recieve an object of type DeleteFinalStateUnknown.
https://godoc.org/k8s.io/client-go/tools/cache#DeletedFinalStateUnknown

If we do recieve one, just ignore it.

@markmandel markmandel added the kind/bug These are bugs. label Feb 26, 2018
@markmandel markmandel added this to the 0.1 milestone Feb 26, 2018
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's possibel the DeleteFunc could recieve an object of type
DeleteFinalStateUnknown.
https://godoc.org/k8s.io/client-go/tools/cache#DeletedFinalStateUnknown

If we do recieve one, just ignore it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants