Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the instructions for manually creating a GKE cluster to disable automatic node upgrades #1140

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Update the instructions for manually creating a GKE cluster to disable automatic node upgrades #1140

merged 1 commit into from
Oct 24, 2019

Conversation

roberthbailey
Copy link
Member

This is the first part of #1137.

As I mentioned in the issue, I think this should be done as part of the 1.1 release.

/assign @markmandel

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7a7a5ff4-d529-4fcb-8477-cd55cfef7bf8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1140/head:pr_1140 && git checkout pr_1140
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-5791026

@roberthbailey roberthbailey added this to the 1.1.0 milestone Oct 23, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a7c1e896-418e-4733-99ee-1adfd16340fb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1140/head:pr_1140 && git checkout pr_1140
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-9897ba3

markmandel
markmandel reviewed Oct 24, 2019
View reviewed changes
site/content/en/docs/Installation/_index.md Show resolved Hide resolved
site/content/en/docs/Installation/_index.md
```bash
gcloud container node-pools create agones-metrics \
--cluster=[CLUSTER_NAME] \
--no-enable-autoupgrade \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here? If grafana/prom restart, is that a bad thing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's a bad thing. But if we've disabled it on the primary node pool and the agones system node pool, we might as well do it for this single node as well so that the whole cluster is running one version on all nodes. It also prevents drift where the cluster will end up in a state that we haven't tested (since we only test on a single k8s version).

site/content/en/docs/Installation/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/Installation/_index.md Outdated Show resolved Hide resolved
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/documentation Documentation for Agones labels Oct 24, 2019
@aLekSer aLekSer mentioned this pull request Oct 24, 2019
Merged
@roberthbailey
Copy link
Member Author

ptal

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a44aa65d-6262-4fcd-98be-d4f7e8a06f0a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1140/head:pr_1140 && git checkout pr_1140
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b3d005f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 582f2b40-d755-4b35-8b64-8da829e57546

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1140/head:pr_1140 && git checkout pr_1140
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-394c048

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit e8dc930 into googleforgames:master Oct 24, 2019
@roberthbailey roberthbailey deleted the disable-auto-upgrades branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@joeholley joeholley Awaiting requested review from joeholley

Assignees

@markmandel markmandel

Labels
approved area/operations Installation, updating, metrics etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel