Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the images for all examples to use the 1.1 SDKs #1153

Merged
merged 5 commits into from
Oct 28, 2019

Conversation

roberthbailey
Copy link
Member

I've already compiled and pushed the new image versions to gcr.io/agones-images.

Fixes #1126.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6e3979d-f93b-440d-a43c-9ada31cdacfc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1153/head:pr_1153 && git checkout pr_1153
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2d51dcc

@roberthbailey
Copy link
Member Author

I added a second commit to fix the vulnerabilities in the go example images (xref #1154).

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f9680f1-ab6d-4d05-a304-3997632d44b9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1153/head:pr_1153 && git checkout pr_1153
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-0ef1b04

@roberthbailey
Copy link
Member Author

/assign @markmandel

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to point the website, unit tests, etc at the new udp-simple tag?

Or should that be a separate PR?

@roberthbailey
Copy link
Member Author

We should re-point them... I can add it to this PR.

@roberthbailey
Copy link
Member Author

I added 3 more commits to update website docs, tests, & example yamls.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c94fd97e-ec31-4975-a77d-6edc67d80ada

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1153/head:pr_1153 && git checkout pr_1153
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-cf8064d

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0bdd74d3-2b13-4d72-bb11-1fa7e33559d3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Weird flakiness showing up.

docker: Error response from daemon: error creating overlay mount to /var/lib/docker/overlay2/d88116843d87c3f152b7b24249f745787a83fae66d618434933a7bc9396b8c96-init/merged: device or resource busy.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fcae6376-a52e-45db-b8ca-768d6c51d0bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1153/head:pr_1153 && git checkout pr_1153
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-c56f70c

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f20f4bde-0b22-4f42-a690-96a4767118c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1153/head:pr_1153 && git checkout pr_1153
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-660f1ed

@markmandel markmandel merged commit 10017be into googleforgames:master Oct 28, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Oct 29, 2019

@markmandel Regarding that error

docker: Error response from daemon: error creating overlay mount to /var/lib/docker/overlay2/d88116843d87c3f152b7b24249f745787a83fae66d618434933a7bc9396b8c96-init/merged: device or resource busy.

So this is a Cloud Build Docker version issue.

This should be fixed in the 2019-09 monthly update (19.03.3, 18.09.10), due next week.

docker/for-linux#711

@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 29, 2019
@roberthbailey roberthbailey deleted the update-example-images branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild example images for the 1.1 release
5 participants