Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spec and Health data to default local sdk GameServer #1166

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add Spec and Health data to default local sdk GameServer #1166

merged 2 commits into from
Nov 1, 2019

Conversation

markmandel
Copy link
Member

Noticed when building the Unity SDK.GameServer(), there was no data in the Spec field that come with the GameServer that comes through the SDK.

This gives it some default values, making it easier to build SDKs against.

@markmandel
Add Spec and Health data to default local sdk GameServer
8b783a4 
Noticed when building the Unity `SDK.GameServer()`, there was no data
in the Spec field that come with the GameServer that comes through
the SDK.

This gives it some default values, making it easier to build SDKs
against.
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Oct 31, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cecb0479-d609-4b5b-95d7-2dd8417b96aa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e5c58f53-9b16-4630-911d-e65d007f8899

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1166/head:pr_1166 && git checkout pr_1166
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-8b783a4

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d7afc1be-5c97-4af7-9738-9cca01753868

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author 

panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range

goroutine 96 [running]:
testing.tRunner.func1(0xc000612700)
	/usr/local/go/src/testing/testing.go:830 +0x68a
panic(0x1967760, 0x2968a20)
	/usr/local/go/src/runtime/panic.go:522 +0x1b5
agones.dev/agones/test/e2e/framework.SendGameServerUDP(0xc000a211b0, 0x1acebb5, 0x9, 0x1cd6840, 0x1905360, 0xc0009296b0, 0x0)
	/go/src/agones.dev/agones/test/e2e/framework/framework.go:305 +0x1fe
agones.dev/agones/test/e2e.TestFleetRecreateGameServers.func3(0xc000612700, 0xc0001f8000)
	/go/src/agones.dev/agones/test/e2e/fleet_test.go:935 +0x108
agones.dev/agones/test/e2e.TestFleetRecreateGameServers.func4(0xc000612700)
	/go/src/agones.dev/agones/test/e2e/fleet_test.go:968 +0x590
testing.tRunner(0xc000612700, 0xc00043e070)
	/usr/local/go/src/testing/testing.go:865 +0x164
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:916 +0x69a
FAIL	agones.dev/agones/test/e2e	128.930s
Makefile:241: recipe for target 'test-e2e' failed
make: *** [test-e2e] Error 1
Error running handler: exit status 2
Child terminated, releasing lock

That's a new one. Haven't seen that one before.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 842c5b05-f033-47e0-a645-4987e0bfcec2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1166/head:pr_1166 && git checkout pr_1166
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-ea22731

@roberthbailey roberthbailey merged commit 551cf53 into googleforgames:master Nov 1, 2019
@markmandel markmandel deleted the feature/local-spec branch November 1, 2019 17:56
@aLekSer aLekSer mentioned this pull request Nov 4, 2019
Merged
@roberthbailey roberthbailey added this to the 1.2.0 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones size/XS
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey