Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whoops - spelling mistake in feature tag. #1204

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

markmandel
Copy link
Member

This should fix things.

We should also do an error if feature shortcode
doesn't have either expiryVersion or publishVersion
https://gohugo.io/templates/shortcode-templates/#error-handling-in-shortcodes

This should fix things.

We should also do an error if feature shortcode
doesn't have either expiryVersion or publishVersion
https://gohugo.io/templates/shortcode-templates/#error-handling-in-shortcodes
@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Dec 4, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e39e6572-86c8-4c27-9a56-ab529169f668

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1204/head:pr_1204 && git checkout pr_1204
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-5d5948b

@markmandel markmandel merged commit 787ea53 into googleforgames:master Dec 4, 2019
@markmandel markmandel deleted the docs/double-trouble branch December 4, 2019 17:55
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
This should fix things.

We should also do an error if feature shortcode
doesn't have either expiryVersion or publishVersion
https://gohugo.io/templates/shortcode-templates/#error-handling-in-shortcodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug These are bugs. kind/documentation Documentation for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants