Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error checking of attributes on feature shortcode #1205

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Error checking of attributes on feature shortcode #1205

merged 2 commits into from
Dec 4, 2019

Conversation

markmandel
Copy link
Member

@markmandel markmandel commented Dec 4, 2019 •
edited
Loading

This should make attribute spelling mistakes much harder to do in the future!

Example output:
2019-12-04_09-58

@markmandel
Error checking of attributes on feature shortcode
18d2592 
This should make attribute spelling mistakes much
harder to do in the future!
@markmandel markmandel added kind/feature New features for Agones area/site The website itself - including redirects, styling, search, etc labels Dec 4, 2019
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 433b08d7-0b9e-4800-8f42-61caec88f624

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1205/head:pr_1205 && git checkout pr_1205
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-18d2592

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 54e06902-f2e4-41da-ae81-c0d6525a2926

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1205/head:pr_1205 && git checkout pr_1205
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-3184fc5

@roberthbailey roberthbailey merged commit 3351c0c into googleforgames:master Dec 4, 2019
@markmandel markmandel deleted the site/feature-error-check branch December 4, 2019 18:42
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Error checking of attributes on feature shortcode (googleforgames#1205)
8a4c45d 
This should make attribute spelling mistakes much
harder to do in the future!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved area/site The website itself - including redirects, styling, search, etc kind/feature New features for Agones size/XS
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @google-oss-robot @agones-bot @roberthbailey