Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Unreal plugin version to 3 #1209

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Setting Unreal plugin version to 3 #1209

merged 1 commit into from
Dec 5, 2019

Conversation

domgreen
Copy link
Contributor

@domgreen domgreen commented Dec 5, 2019

Think the FileVersion on the UE Pluigin was bumped by accident.

See docs:

"FileVersion" gives the version of the Plugin descriptor file, and should usually set to the highest version that is allowed by the Engine (currently, this is "3")

Link https://docs.unrealengine.com/en-US/Programming/Plugins/index.html

Signed-off-by: Dominic Green dominicgreen1@gmail.com

Signed-off-by: Dominic Green <dominicgreen1@gmail.com>
@domgreen
Copy link
Contributor Author

domgreen commented Dec 5, 2019

/assign @EricFortin

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 343bd215-7826-4905-90cd-e088008c0ca1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Would we consider this a bug fix?

Just checking, since we're in feature freeze atm, but if it's a bug fix, it can come through.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1b54a48b-5f70-4ecf-9d40-a382167e627a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0157e480-83da-4fef-9a12-897cd9178b8c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1209/head:pr_1209 && git checkout pr_1209
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-7ed43e7

@domgreen
Copy link
Contributor Author

domgreen commented Dec 5, 2019

Would we consider this a bug fix?

Just checking, since we're in feature freeze atm, but if it's a bug fix, it can come through.

Yep, I would consider this a bug fix ... without this Unreal was unable to load the Agones plugin due to an invalid FileVersion.

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Dec 5, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 5, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit b7f47e7 into googleforgames:master Dec 5, 2019
@domgreen
Copy link
Contributor Author

domgreen commented Dec 5, 2019

Thanks.

For completenes here is a screenshot of the bug:
image

@domgreen domgreen deleted the unrealpluginversion branch December 5, 2019 19:32
@markmandel
Copy link
Member

Thanks for pushing this through! We definitely need the Unreal expertise!

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Signed-off-by: Dominic Green <dominicgreen1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants