Split installation guide into separate sections #1211

markmandel · 2019-12-06T01:39:45Z

Something I've wanted to do for a really long time.

Break down cluster creation into a page per cloud provider
Break down installation into separate pages per installation type
Pull Terraform into its own area, and split per cloud provider a well.

Should be much easier to go through now.

agones-bot · 2019-12-06T01:53:40Z

Build Succeeded 👏

Build Id: 48a453a0-4410-4d27-9575-13178f059ced

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-7293852
image: gcr.io/agones-images/agones-sdk:1.2.0-7293852
image: gcr.io/agones-images/agones-ping:1.2.0-7293852
Linux C++ SDK (build): agonessdk-1.2.0-7293852-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-7293852.zip

A preview of the website (the last 30 builds are retained):

https://7293852-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1211/head:pr_1211 && git checkout pr_1211
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-7293852

markmandel · 2019-12-06T01:57:56Z

The updated area in question:
https://7293852-dot-preview-dot-agones-images.appspot.com/site/docs/installation/

site/content/en/docs/Installation/Creating Cluster/_index.md

site/content/en/docs/Installation/Creating Cluster/aks.md

site/content/en/docs/Installation/Terraform/gke.md

site/content/en/docs/Installation/_index.md

roberthbailey · 2019-12-09T17:42:33Z

Sorry for the delay on the review; this took quite a bit longer to read through than I thought it would.

markmandel · 2019-12-09T17:49:52Z

Sorry for the delay on the review; this took quite a bit longer to read through than I thought it would.

No worries at all. I pretty much just moved things around - looks like you did a full review of the getting started experience - which is probably well overdue! At first pass, looks like lots of good stuff! Will go through.

agones-bot · 2019-12-10T02:06:06Z

Build Failed 😱

Build Id: 7a1295a0-dcd4-42ff-ab05-2c2d029f74ee

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-12-10T06:23:47Z

Looks like a couple of broken links:

========================================================================
site/docs/installation/creating-cluster/gke/index.html
  target does not exist --- site/docs/installation/creating-cluster/gke/index.html --> /images/cloud-shell.png
site/docs/installation/terraform/gke/index.html
  target does not exist --- site/docs/installation/terraform/gke/index.html --> /images/cloud-shell.png
========================================================================

markmandel · 2019-12-11T01:21:15Z

Will fix up once the next release is out 👍

agones-bot · 2019-12-12T23:59:14Z

Build Succeeded 👏

Build Id: 42c70536-6e44-441c-8bd9-69aa04d9de5c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-d383b6e
image: gcr.io/agones-images/agones-sdk:1.3.0-d383b6e
image: gcr.io/agones-images/agones-ping:1.3.0-d383b6e
Linux C++ SDK (build): agonessdk-1.3.0-d383b6e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-d383b6e.zip

A preview of the website (the last 30 builds are retained):

https://d383b6e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1211/head:pr_1211 && git checkout pr_1211
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-d383b6e

markmandel · 2019-12-18T17:53:32Z

/assign @roberthbailey

This should be cleaned up now, and conflicts resolved. Is this good to go?

agones-bot · 2019-12-18T18:01:38Z

Build Failed 😱

Build Id: 9e789169-4252-4d52-9da7-a928afc33b74

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-18T18:50:56Z

Build Failed 😱

Build Id: 8c907c93-df9a-4edf-a037-405df3aae757

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-18T19:11:30Z

Build Succeeded 👏

Build Id: 27b308fa-b8c7-4955-afb3-ae28c1c74d84

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-bcf21c1
image: gcr.io/agones-images/agones-sdk:1.3.0-bcf21c1
image: gcr.io/agones-images/agones-ping:1.3.0-bcf21c1
Linux C++ SDK (build): agonessdk-1.3.0-bcf21c1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-bcf21c1.zip

A preview of the website (the last 30 builds are retained):

https://bcf21c1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1211/head:pr_1211 && git checkout pr_1211
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-bcf21c1

site/content/en/docs/Installation/Terraform/aks.md

site/content/en/docs/Installation/Terraform/gke.md

site/content/en/docs/Installation/_index.md

site/content/en/docs/Installation/Install Agones/helm.md

roberthbailey · 2019-12-19T09:31:20Z

This is looking much, much better. Just a few more things to tidy up and this will be ready to push live.

agones-bot · 2019-12-20T01:06:43Z

Build Failed 😱

Build Id: 7276fb4d-3669-4bcd-a668-1b3cbe2a3f13

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-12-20T03:35:58Z

From the latest build:

ERROR 2019/12/20 01:05:14 [en] REF_NOT_FOUND: Ref "/docs/Installation/helm.md": "/go/src/agones.dev/agones/site/content/en/docs/Guides/feature-stages.md:23:47": page not found

markmandel · 2019-12-20T18:05:33Z

😠 always get bit by that on rebase! shakes fist at the sky

Something I've wanted to do for a really long time. - Break down cluster creation into a page per cloud provider - Break down installation into separate pages per installation type - Pull Terraform into its own area, and split per cloud provider a well. Should be much easier to go through now.

agones-bot · 2019-12-20T18:57:13Z

Build Failed 😱

Build Id: 0e93279d-7df3-4b31-8cc7-e210169205f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-12-20T19:07:57Z

Every so often conformance tests fail... but it's super rare. Any ideas @aLekSer ?

{"message":"Testing Failed [ready allocate setlabel setannotation gameserver health shutdown watch reserve] [watch ready reserve allocate health setlabel setannotation shutdown]","severity":"info","time":"2019-12-20T18:53:13.625535624Z"}
make[2]: *** [run-sdk-conformance-no-build] Error 1
includes/sdk.mk:139: recipe for target 'run-sdk-conformance-no-build' failed
make[1]: *** [run-sdk-conformance-test] Error 2
includes/sdk.mk:146: recipe for target 'run-sdk-conformance-test' failed
includes/sdk.mk:153: recipe for target 'run-sdk-conformance-test-go' failed

agones-bot · 2019-12-20T19:20:04Z

Build Succeeded 👏

Build Id: bc404352-0e32-46b0-afc3-7e8092a2415b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-cc80603
image: gcr.io/agones-images/agones-sdk:1.3.0-cc80603
image: gcr.io/agones-images/agones-ping:1.3.0-cc80603
Linux C++ SDK (build): agonessdk-1.3.0-cc80603-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-cc80603.zip

A preview of the website (the last 30 builds are retained):

https://cc80603-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1211/head:pr_1211 && git checkout pr_1211
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-cc80603

google-oss-robot · 2019-12-20T19:34:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aLekSer · 2020-01-29T18:34:18Z

@markmandel I will look into SDK conformance fluctuation, please let me know of any new failure.

Something I've wanted to do for a really long time. - Break down cluster creation into a page per cloud provider - Break down installation into separate pages per installation type - Pull Terraform into its own area, and split per cloud provider a well. Should be much easier to go through now.

markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 6, 2019

google-oss-robot requested review from dzlier-gcp and roberthbailey December 6, 2019 01:39

google-oss-robot added approved size/XXL labels Dec 6, 2019

roberthbailey reviewed Dec 9, 2019

View reviewed changes

markmandel force-pushed the docs/split-install branch from 7293852 to 91c8aff Compare December 10, 2019 01:57

markmandel force-pushed the docs/split-install branch from 91c8aff to d383b6e Compare December 12, 2019 23:44

markmandel force-pushed the docs/split-install branch from d383b6e to d988624 Compare December 18, 2019 17:53

google-oss-robot assigned roberthbailey Dec 18, 2019

markmandel force-pushed the docs/split-install branch from d988624 to bcf21c1 Compare December 18, 2019 18:37

roberthbailey reviewed Dec 19, 2019

View reviewed changes

markmandel force-pushed the docs/split-install branch from bcf21c1 to a95b644 Compare December 20, 2019 00:58

markmandel force-pushed the docs/split-install branch from a95b644 to cc80603 Compare December 20, 2019 18:45

roberthbailey approved these changes Dec 20, 2019

View reviewed changes

google-oss-robot added the lgtm label Dec 20, 2019

roberthbailey merged commit 041288a into googleforgames:master Dec 20, 2019

markmandel deleted the docs/split-install branch December 20, 2019 19:35

markmandel added this to the 1.3.0 milestone Jan 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split installation guide into separate sections #1211

Split installation guide into separate sections #1211

markmandel commented Dec 6, 2019

agones-bot commented Dec 6, 2019

markmandel commented Dec 6, 2019

roberthbailey commented Dec 9, 2019

markmandel commented Dec 9, 2019

agones-bot commented Dec 10, 2019

roberthbailey commented Dec 10, 2019

markmandel commented Dec 11, 2019

agones-bot commented Dec 12, 2019

markmandel commented Dec 18, 2019

agones-bot commented Dec 18, 2019

agones-bot commented Dec 18, 2019

agones-bot commented Dec 18, 2019

roberthbailey commented Dec 19, 2019

agones-bot commented Dec 20, 2019

roberthbailey commented Dec 20, 2019

markmandel commented Dec 20, 2019

agones-bot commented Dec 20, 2019

markmandel commented Dec 20, 2019

agones-bot commented Dec 20, 2019

google-oss-robot commented Dec 20, 2019

aLekSer commented Jan 29, 2020

Split installation guide into separate sections #1211

Split installation guide into separate sections #1211

Conversation

markmandel commented Dec 6, 2019

agones-bot commented Dec 6, 2019

markmandel commented Dec 6, 2019

roberthbailey commented Dec 9, 2019

markmandel commented Dec 9, 2019

agones-bot commented Dec 10, 2019

roberthbailey commented Dec 10, 2019

markmandel commented Dec 11, 2019

agones-bot commented Dec 12, 2019

markmandel commented Dec 18, 2019

agones-bot commented Dec 18, 2019

agones-bot commented Dec 18, 2019

agones-bot commented Dec 18, 2019

roberthbailey commented Dec 19, 2019

agones-bot commented Dec 20, 2019

roberthbailey commented Dec 20, 2019

markmandel commented Dec 20, 2019

agones-bot commented Dec 20, 2019

markmandel commented Dec 20, 2019

agones-bot commented Dec 20, 2019

google-oss-robot commented Dec 20, 2019

aLekSer commented Jan 29, 2020