Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GRPC to v1.20.1 #1215

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Update GRPC to v1.20.1 #1215

merged 2 commits into from
Dec 12, 2019

Conversation

markmandel
Copy link
Member

Taking over work started in #1144, so we can upgrade Opencensus

  • Updates gRPC in all places, which updates proto and grpc-gateway
  • Regenerates the code for all gRPC SDKs as well
  • Need to workaround a issue with the /watch Swagger codegen, as the swagger changed between versions.
    This likely means the JSON structure from grpc-gateway for streaming operations also changed.
    This is a breaking change, but we have no control over it (not sure if anyone is using this
    specific REST api endpoint, so it's probably a non issue).
  • Use the C++ library requisites file in the cloud build cache key, so it gets updated
    as dependencies get updated.

Closes #1214

Co-authored-by: Cyril Tovena cyril.tovena@gmail.com

@cyriltovena @markmandel
Update GRPC to v1.20.1
3e0b5e8 
Taking over work started in googleforgames#1144, so we can upgrade Opencensus

- Updates gRPC in all places, which updates proto and grpc-gateway
- Regenerates the code for all gRPC SDKs as well
- Need to workaround a issue with the /watch Swagger codegen, as the swagger changed between versions.
  This likely means the JSON structure from grpc-gateway for streaming operations also changed.
  This is a breaking change, but we have no control over it (not sure if anyone is using this
  specific REST api endpoint, so it's probably a non issue).
- Use the C++ library requisites file in the cloud build cache key, so it gets updated
  as dependencies get updated.

Closes googleforgames#1214

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change labels Dec 7, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 90ca2032-4f4e-4418-9e15-36aad6be59bc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1215/head:pr_1215 && git checkout pr_1215
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-3e0b5e8

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 7, 2019
cyriltovena
cyriltovena approved these changes Dec 8, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Mark, not sure why the CLA bot is not happy.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyriltovena, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cyriltovena,markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member Author

@cyriltovena because I put you as an additional author, you need to say @googlebot I consent. in a comment, and then it's good to go when we get out of feature freeze next week.

@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 12, 2019
@markmandel markmandel marked this pull request as ready for review December 12, 2019 00:33
@cyriltovena
Copy link
Collaborator

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e4ce7d7e-9b4e-4f6d-b4f1-18de9f28fef4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1215/head:pr_1215 && git checkout pr_1215
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-119181f

@markmandel markmandel merged commit 1e43f12 into googleforgames:master Dec 12, 2019
@markmandel markmandel deleted the pull/1144 branch December 12, 2019 02:33
@markmandel markmandel added this to the 1.3.0 milestone Jan 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @cyriltovena @ilkercelikyilmaz
Update GRPC to v1.20.1 (googleforgames#1215)
359c095 
Taking over work started in googleforgames#1144, so we can upgrade Opencensus

- Updates gRPC in all places, which updates proto and grpc-gateway
- Regenerates the code for all gRPC SDKs as well
- Need to workaround a issue with the /watch Swagger codegen, as the swagger changed between versions.
  This likely means the JSON structure from grpc-gateway for streaming operations also changed.
  This is a breaking change, but we have no control over it (not sure if anyone is using this
  specific REST api endpoint, so it's probably a non issue).
- Use the C++ library requisites file in the cloud build cache key, so it gets updated
  as dependencies get updated.

Closes googleforgames#1214

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@devjgm devjgm Awaiting requested review from devjgm

@EricFortin EricFortin Awaiting requested review from EricFortin

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

Assignees

@cyriltovena cyriltovena

Labels
approved kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc size/XXL
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Updates GRPC to v1.20.1
5 participants
@markmandel @googlebot @agones-bot @google-oss-robot @cyriltovena