Revert: Make it possible to create a Fleet with 0 replicas #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts some of the changes in googleforgames#1168, which introduced a breaking change that defaulted Fleets to have 1 replica. Due to the nature of Go, this also meant that if you attempted to create a Fleet with 0 replicas, it would change it to being 1 replica. Implemented this fix to ensure there is no breaking change in the release and its also useful to be able to create Fleets with 0 replicas in them. Also including an extra e2e test to make sure creating a Fleet with 0 replicas continues to function into the future.
markmandel
added
kind/bug
|
@aLekSer do you see any issue with this change? |
pooneh-m
approved these changes
Dec 10, 2019
|
Build Succeeded 👏 Build Id: 04fb38a7-fa2f-45d8-8e6b-4d42dbb001af The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Thanks for the quick approval. Going to wait on @aLekSer 's feedback before merging, and restarting the release process. |
|
I think it would be useful. Thanks for fixing this issue. |
roberthbailey
approved these changes
Dec 11, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
…games#1226) This reverts some of the changes in googleforgames#1168, which introduced a breaking change that defaulted Fleets to have 1 replica. Due to the nature of Go, this also meant that if you attempted to create a Fleet with 0 replicas, it would change it to being 1 replica. Implemented this fix to ensure there is no breaking change in the release and its also useful to be able to create Fleets with 0 replicas in them. Also including an extra e2e test to make sure creating a Fleet with 0 replicas continues to function into the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts some of the changes in #1168, which introduced a breaking change that defaulted Fleets to have 1 replica.
Due to the nature of Go, this also meant that if you attempted to create a Fleet with 0 replicas, it would change it to being 1 replica.
Implemented this fix to ensure there is no breaking change in the release and its also useful to be able to create Fleets with 0 replicas in them.
Also including an extra e2e test to make sure creating a Fleet with 0 replicas continues to function into the future.