Move conflict messaged to Debug Logging #1232
Conversation
markmandel
added
kind/cleanup
|
Build Succeeded 👏 Build Id: a9d8dfc3-5ecf-4aa4-8dc6-ba9effcf62d7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyriltovena, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/util/workerqueue/workerqueue.go
Outdated
| @@ -150,8 +151,14 @@ func (wq *WorkerQueue) processNextWorkItem() bool { | |||
| } | |||
|
|
|||
| if err := wq.SyncHandler(key); err != nil { | |||
| // Conflicts are expected, so only show them in debug operations. | |||
| if k8serror.IsConflict(err) { | |||
| wq.logger.Debug(err) | |||
There was a problem hiding this comment.
Should this also use the WithField to include the keyName in the debug log?
There was a problem hiding this comment.
That's a good idea. I'll make that change 👍
markmandel
force-pushed
the
logging/debug-conflict
branch
from
dc57487
to
81f1cc6
Compare
|
New changes are detected. LGTM label has been removed. |
2 similar comments
|
New changes are detected. LGTM label has been removed. |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 4c93a5ad-c9bd-4865-bfde-f05492382623 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Conflicts when attempting to update Kubernetes resources is expected and will happen frequently in Agones. Currently they are reported as errors, and (a) produce a lot of noise, and (b) are reported as errors, which can often be seen as potential issues by end users, as well as red-herring reasons for actual issues. We may want to wait until googleforgames#1220 is complete before merging. Will help with issues also raised in googleforgames#1218.
markmandel
force-pushed
the
logging/debug-conflict
branch
from
81f1cc6
to
a16bf28
Compare
|
Build Succeeded 👏 Build Id: 7bc38dce-a89a-4f31-9e70-c65106bcee2d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Conflicts when attempting to update Kubernetes resources is expected and will happen frequently in Agones. Currently they are reported as errors, and (a) produce a lot of noise, and (b) are reported as errors, which can often be seen as potential issues by end users, as well as red-herring reasons for actual issues. We may want to wait until googleforgames#1220 is complete before merging. Will help with issues also raised in googleforgames#1218.
Conflicts when attempting to update Kubernetes resources is expected and will happen frequently in Agones.
Currently they are reported as errors, and (a) produce a lot of noise, and (b) are reported as errors, which can often be seen as potential issues by end users, as well as red-herring reasons for actual issues.
We may want to wait until #1220 is complete before merging.
Will help with issues also raised in #1218.