Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Half the width of the Embark Logo #1242

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Half the width of the Embark Logo #1242

merged 1 commit into from
Dec 18, 2019

Conversation

luna-duclos
Copy link
Contributor

The embark logo is much taller than the others and looks absolutely huge when shown the same width as the others, this halves this so it shows roughly equally big to the other logos

@luna-duclos
Half the width of the Embark Logo
e6435e7 
The embark logo is much taller than the others and looks absolutely huge when shown the same width as the others, this halves this so it shows roughly equally big to the other logos
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0f9b00f4-ee4c-4226-8f86-79ed7592b4fa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1242/head:pr_1242 && git checkout pr_1242
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-e6435e7

@markmandel markmandel added area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 18, 2019
markmandel
markmandel approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nicer!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luna-duclos, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit fc825a6 into googleforgames:master Dec 18, 2019
@markmandel markmandel added this to the 1.3.0 milestone Dec 18, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@luna-duclos @ilkercelikyilmaz
Half the width of the Embark Logo (googleforgames#1242)
1ffd7b5 
The embark logo is much taller than the others and looks absolutely huge when shown the same width as the others, this halves this so it shows roughly equally big to the other logos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luna-duclos @agones-bot @google-oss-robot @markmandel