Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alpine image to 3.11 #1253

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Update Alpine image to 3.11 #1253

merged 2 commits into from
Jan 6, 2020

Conversation

markmandel
Copy link
Member

I think it's been about a year since we updated minor version.

This should also resolve a security issue in musl.

@markmandel
Update Alpine image to 3.11
9fddf43 
I think it's been about a year since we updated minor version.

This should also resolve a security issue in musl.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/security Issues pertaining to security labels Dec 30, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5b495f7f-a382-4c06-b270-0365aed2ea5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1253/head:pr_1253 && git checkout pr_1253
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-9fddf43

@roberthbailey
Copy link
Member

There are some dockerfiles in the examples directory that could use this update as well. Do you want to include those in this change or send a separate PR?

@markmandel
Copy link
Member Author

I was thinking separate PR. The Alpine images for the examples also need doing, so we could do a full example image update set of PRs to update all the things on images.

Also, examples being updated felt like a much lower priority IMHO than our deployed infrastructure.

Should I create a "Update example images" ticket, with things like language choice, alpine image, SDK, etc?

@markmandel markmandel mentioned this pull request Jan 6, 2020
Merged
@roberthbailey
Copy link
Member

Should I create a "Update example images" ticket, with things like language choice, alpine image, SDK, etc?

SGTM.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6ca55735-9dd9-4fb4-9fe2-b88998ae2bfe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1253/head:pr_1253 && git checkout pr_1253
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6a1c346

@roberthbailey roberthbailey merged commit c798920 into googleforgames:master Jan 6, 2020
@markmandel markmandel deleted the cleanup/alpine branch January 7, 2020 00:55
@markmandel markmandel added this to the 1.3.0 milestone Jan 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @roberthbailey @ilkercelikyilmaz
Update Alpine image to 3.11 (googleforgames#1253)
780c9dc 
I think it's been about a year since we updated minor version.

This should also resolve a security issue in musl.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @google-oss-robot