Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to Helm installation #1270

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Fix broken link to Helm installation #1270

merged 2 commits into from
Jan 13, 2020

Conversation

mdanzinger
Copy link
Contributor

No description provided.

@mdanzinger
Copy link
Contributor Author

/assign @EricFortin

markmandel
markmandel approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix!

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jan 13, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, mdanzinger, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6cfa7150-9729-4ced-ace2-4792f0f73e3f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1270/head:pr_1270 && git checkout pr_1270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-74d0e70

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e217f62b-2b25-4c0b-99de-c1bc339ee381

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1270/head:pr_1270 && git checkout pr_1270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-cde5938

@roberthbailey roberthbailey merged commit 6d1df3f into googleforgames:master Jan 13, 2020
@markmandel markmandel added this to the 1.3.0 milestone Jan 14, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@mdanzinger @roberthbailey @ilkercelikyilmaz
Fix broken link to Helm installation (googleforgames#1270)
a9e8779 
Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@markmandel markmandel markmandel approved these changes

Assignees

@markmandel markmandel

@EricFortin EricFortin

@roberthbailey roberthbailey

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mdanzinger @google-oss-robot @agones-bot @markmandel @roberthbailey @EricFortin