Workerqueue IsConflict needed to check error Cause #1310
Conversation
Because errors are often wrapped, when checking Kubernetes error types on anything other than errors comming straight from Kubernetes, we should be using `errors.Cause(err)` to find the root error. Otherwise, this check continues to passes down to the error handler, which defeated the purposes of the original fix.
markmandel
added
kind/bug
markmandel
changed the title
|
Build Succeeded 👏 Build Id: 9cd8645e-f147-4609-b094-e2a79ef75eda The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Failed 😱 Build Id: 20636f7b-d87b-4099-b915-185941c9ce99 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: a60b1408-ba83-44a1-80d0-74df8a1c095f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 08f93941-ff36-4459-8809-c5a211626e47 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: fb3e58bd-2ed7-442a-abbf-a40c22c36fdf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Because errors are often wrapped, when checking Kubernetes error types on anything other than errors comming straight from Kubernetes, we should be using `errors.Cause(err)` to find the root error. Otherwise, this check continues to passes down to the error handler, which defeated the purposes of the original fix. Co-authored-by: Robert Bailey <robertbailey@google.com>
Because errors are often wrapped, when checking Kubernetes error types on anything other than errors comming straight from Kubernetes, we should be using
errors.Cause(err)to find the root error.Otherwise, this check continues to passes down to the error handler, which defeated the purposes of the original fix.