Support UE4 BuildSettingsVersion.V2

[drichardson]

Fixes #1318

Tested against default UE4 4.24 C++ project using the following two Target.cs files:

V1

// Copyright 1998-2019 Epic Games, Inc. All Rights Reserved.

using UnrealBuildTool;
using System.Collections.Generic;

public class AgonesTestEditorTarget : TargetRules
{
	public AgonesTestEditorTarget( TargetInfo Target) : base(Target)
	{
		Type = TargetType.Editor;
		DefaultBuildSettings = BuildSettingsVersion.V1;
		ExtraModuleNames.AddRange( new string[] { "AgonesTest" } );
	}
}

V2

// Copyright 1998-2019 Epic Games, Inc. All Rights Reserved.

using UnrealBuildTool;
using System.Collections.Generic;

public class AgonesTestEditorTarget : TargetRules
{
	public AgonesTestEditorTarget( TargetInfo Target) : base(Target)
	{
		Type = TargetType.Editor;
		DefaultBuildSettings = BuildSettingsVersion.V2;
		ExtraModuleNames.AddRange( new string[] { "AgonesTest" } );
	}
}

[markmandel]

@WVerlaek - are you able to take a look at this and the underlying issue?

[agones-bot]

Build Succeeded 👏

Build Id: ea1f9dec-d0d4-486f-8d60-58a12a1718dc

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.4.0-59458ec
• image: gcr.io/agones-images/agones-sdk:1.4.0-59458ec
• image: gcr.io/agones-images/agones-ping:1.4.0-59458ec
• Linux C++ SDK (build): agonessdk-1.4.0-59458ec-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.4.0-59458ec.zip

A preview of the website (the last 30 builds are retained):

• https://59458ec-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1319/head:pr_1319 && git checkout pr_1319
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-59458ec

[WVerlaek]

LGTM, thanks for finding/fixing this. Have also verified this still works on a UE4.22 project

[google-oss-robot]

@WVerlaek: changing LGTM is restricted to collaborators

In response to this:

LGTM, thanks for finding/fixing this. Have also verified this still works on a UE4.22 project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[markmandel]

Thanks for doing the review! Approving!

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drichardson, markmandel, WVerlaek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: 0a7da008-5fc4-4e29-8fb3-849e4f47c9e4

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 7cc6fc55-2ed5-4073-bef7-65caae7868f3

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.4.0-92426ba
• image: gcr.io/agones-images/agones-sdk:1.4.0-92426ba
• image: gcr.io/agones-images/agones-ping:1.4.0-92426ba
• Linux C++ SDK (build): agonessdk-1.4.0-92426ba-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.4.0-92426ba.zip

A preview of the website (the last 30 builds are retained):

• https://92426ba-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1319/head:pr_1319 && git checkout pr_1319
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-92426ba

[agones-bot]

Build Succeeded 👏

Build Id: 562069bb-cb30-46a9-b5c0-8aae8db75f98

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.4.0-6cf2b7f
• image: gcr.io/agones-images/agones-sdk:1.4.0-6cf2b7f
• image: gcr.io/agones-images/agones-ping:1.4.0-6cf2b7f
• Linux C++ SDK (build): agonessdk-1.4.0-6cf2b7f-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.4.0-6cf2b7f.zip

A preview of the website (the last 30 builds are retained):

• https://6cf2b7f-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1319/head:pr_1319 && git checkout pr_1319
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-6cf2b7f