Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1318 for the release-1.3.0 branch. #1320

Closed
wants to merge 1 commit into from
Closed

Fix #1318 for the release-1.3.0 branch. #1320

wants to merge 1 commit into from

Conversation

drichardson
Copy link
Contributor

This is a fix for #1318 targeted at the release-1.3.0 branch in case a release-1.3.1 is made. This is useful for anyone on UE 4.24 since at the moment the release version of Agones UE4 plugin is not buildable with a default UE4 4.24 C++ project.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drichardson
To complete the pull request process, please assign pooneh-m
You can assign the PR to them by writing /assign @pooneh-m in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@drichardson
Copy link
Contributor Author

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3edcd8fd-5156-403f-a53a-f6c311ab9769

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1320/head:pr_1320 && git checkout pr_1320
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-0625d42

@markmandel
Copy link
Member

Since we release every six weeks, we don't take backported fixes, unless there is a strong reason to hotfix - as then it would cause another release.

So thanks for the effort, but I'm going to close this PR. If people need the fix, they can use the SDK in master 👍

@markmandel markmandel closed this Feb 5, 2020
@markmandel markmandel added the wontfix Sorry, but we're not going to do that. label Feb 5, 2020
@drichardson drichardson deleted the fix-1319-for-agones-1.13.0 branch February 5, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS wontfix Sorry, but we're not going to do that.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants