Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kubernetes terraform provider version #1353

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Fix Kubernetes terraform provider version #1353

merged 3 commits into from
Feb 20, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 20, 2020 •
edited
Loading

Use older version, fix variables for AKS
Removed deprecated field agent_pool_profile in favor of new default_node_pool which would be required in next version.

There is a know bug in the most recent 1.11.0 version hashicorp/terraform-provider-kubernetes#759, so in order to retiliate this issue we should avoid the most recent version.

For #1329

Error was the following;

Error: Failed to initialize config: invalid configuration: no configuration has been provided

  on .terraform/modules/agones/install/terraform/helm.tf line 90, in provider "kubernetes":
  90: provider "kubernetes" {

@aLekSer
Fix Kubernetes terraform provider
cd4405a 
Use older version, fix variables for AKS
@aLekSer aLekSer force-pushed the fix/terraform-aks-helm branch from 0d16ccf to cd4405a Compare February 20, 2020 15:23
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b2bbe5db-7a7f-4420-b1b6-42860e898658

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1353/head:pr_1353 && git checkout pr_1353
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-0d16ccf

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 459ada91-2c03-4633-820f-b2652d7d74d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1353/head:pr_1353 && git checkout pr_1353
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-cd4405a

cyriltovena
cyriltovena approved these changes Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, cyriltovena, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cyriltovena,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f0fef8e3-7e6f-44b4-8f51-62e1c737a630

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1353/head:pr_1353 && git checkout pr_1353
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-cb6cfe1

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec13b05f-ebd7-43eb-9137-6991de627f4b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1353/head:pr_1353 && git checkout pr_1353
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-3c387d3

@markmandel markmandel merged commit 7d4789e into googleforgames:master Feb 20, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 21, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 21, 2020
@roberthbailey roberthbailey mentioned this pull request Feb 25, 2020
Closed
29 tasks
@aLekSer aLekSer mentioned this pull request Mar 19, 2020
Merged
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @cyriltovena
@markmandel @ilkercelikyilmaz
Fix Kubernetes terraform provider (googleforgames#1353)
e2a9c5f 
Use older version, fix variables for AKS

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Co-authored-by: Mark Mandel <mark.mandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@cyriltovena cyriltovena

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aLekSer @agones-bot @google-oss-robot @cyriltovena @roberthbailey @markmandel