Updated log levels in pkg #1359

akremsa · 2020-02-24T11:09:39Z

This PR can be considered as a part of #1223

Updated log levels in pkg package.

agones-bot · 2020-02-24T11:26:14Z

Build Succeeded 👏

Build Id: 2afcd540-bf92-4442-b2df-b1c124562a03

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-966676d
image: gcr.io/agones-images/agones-sdk:1.4.0-966676d
image: gcr.io/agones-images/agones-ping:1.4.0-966676d
Linux C++ SDK (build): agonessdk-1.4.0-966676d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-966676d.zip

A preview of the website (the last 30 builds are retained):

https://966676d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-966676d

agones-bot · 2020-02-24T14:18:40Z

Build Failed 😱

Build Id: 787d674b-d4aa-4d8e-9b6c-9977ecb68b43

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-25T10:11:48Z

Build Succeeded 👏

Build Id: 93e7d229-ff62-42a3-9027-0f0f92e5e35c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-744fdd3
image: gcr.io/agones-images/agones-sdk:1.4.0-744fdd3
image: gcr.io/agones-images/agones-ping:1.4.0-744fdd3
Linux C++ SDK (build): agonessdk-1.4.0-744fdd3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-744fdd3.zip

A preview of the website (the last 30 builds are retained):

https://744fdd3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-744fdd3

agones-bot · 2020-02-25T10:15:04Z

Build Succeeded 👏

Build Id: 16cc8cd4-191e-40ec-b1b6-0602b14ba262

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-1b7a331
image: gcr.io/agones-images/agones-sdk:1.4.0-1b7a331
image: gcr.io/agones-images/agones-ping:1.4.0-1b7a331
Linux C++ SDK (build): agonessdk-1.4.0-1b7a331-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-1b7a331.zip

A preview of the website (the last 30 builds are retained):

https://1b7a331-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-1b7a331

pkg/sdkserver/localsdk.go

agones-bot · 2020-02-26T12:42:47Z

Build Succeeded 👏

Build Id: 800f6752-3751-4c1b-8b3a-934929d7afa9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-76321a0
image: gcr.io/agones-images/agones-sdk:1.4.0-76321a0
image: gcr.io/agones-images/agones-ping:1.4.0-76321a0
Linux C++ SDK (build): agonessdk-1.4.0-76321a0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-76321a0.zip

A preview of the website (the last 30 builds are retained):

https://76321a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-76321a0

CONTRIBUTING.md

markmandel

Outside of moving the CONTRIBUTING.md change to a new PR, and @aLekSer 's nit, this looks good to go for me. Once those changes are in, I'm happy to approve.

agones-bot · 2020-02-27T09:56:44Z

Build Succeeded 👏

Build Id: 4a77a221-bfe5-4a40-871e-34b01fb856b5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-f656eaf
image: gcr.io/agones-images/agones-sdk:1.4.0-f656eaf
image: gcr.io/agones-images/agones-ping:1.4.0-f656eaf
Linux C++ SDK (build): agonessdk-1.4.0-f656eaf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-f656eaf.zip

A preview of the website (the last 30 builds are retained):

https://f656eaf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-f656eaf

agones-bot · 2020-02-27T09:59:49Z

Build Failed 😱

Build Id: 055ae952-47c6-4880-85c0-f56845930328

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

akremsa · 2020-02-27T10:13:29Z

@markmandel thanks for the review. I've removed changes from the md file and added other log levels updates to this PR because all of them are related to the same package - pkg, and I think it's better to keep everything in a single PR.

agones-bot · 2020-02-27T10:20:45Z

Build Failed 😱

Build Id: b192871b-b93c-423a-bfa6-589ad0cf3f5e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-27T10:22:59Z

Build Failed 😱

Build Id: 328bb4f6-b919-434b-8e9a-c3991a6acb1a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-28T13:40:33Z

Build Failed 😱

Build Id: d0b59459-2f8e-4966-97f6-0698b811fc17

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-02T09:55:50Z

Build Succeeded 👏

Build Id: 3a65be0d-fc0e-4f4d-887e-ea45013fd0f5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-378f9a9
image: gcr.io/agones-images/agones-sdk:1.4.0-378f9a9
image: gcr.io/agones-images/agones-ping:1.4.0-378f9a9
Linux C++ SDK (build): agonessdk-1.4.0-378f9a9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-378f9a9.zip

A preview of the website (the last 30 builds are retained):

https://378f9a9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-378f9a9

akremsa · 2020-03-03T09:00:45Z

/assign @markmandel

agones-bot · 2020-03-03T09:18:50Z

Build Succeeded 👏

Build Id: 90467466-57d5-47c1-8373-4d57a746824d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-97d79f4
image: gcr.io/agones-images/agones-sdk:1.4.0-97d79f4
image: gcr.io/agones-images/agones-ping:1.4.0-97d79f4
Linux C++ SDK (build): agonessdk-1.4.0-97d79f4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-97d79f4.zip

A preview of the website (the last 30 builds are retained):

https://97d79f4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-97d79f4

aLekSer · 2020-03-04T12:03:29Z

@markmandel I think we could merge this PR before the release. It would significantly reduce logging in SDK server with Info level used by default.
There could be a plenty of GameServers and so number of logs would be reduced by Replicas count in all Fleets.

agones-bot · 2020-03-04T12:12:41Z

Build Failed 😱

Build Id: 526ce469-1338-49a9-aa23-f6248215a12a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-04T12:28:03Z

Build Failed 😱

Build Id: 4b3aad55-9344-4d93-b25e-5a4033834f15

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-04T13:23:51Z

Build Failed 😱

Build Id: ba29a176-537a-45d7-9f46-5adfb9eac803

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Minor fixes

agones-bot · 2020-03-05T11:18:27Z

Build Failed 😱

Build Id: 2dc544ba-462c-4824-b31b-9196955f4389

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2020-03-05T13:28:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign markmandel
You can assign the PR to them by writing /assign @markmandel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-03-05T23:12:11Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-03-05T23:31:32Z

Build Succeeded 👏

Build Id: 30e2b327-041b-46e5-b2ee-b65f2ceec2f2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-2aae596
image: gcr.io/agones-images/agones-sdk:1.5.0-2aae596
image: gcr.io/agones-images/agones-ping:1.5.0-2aae596
Linux C++ SDK (build): agonessdk-1.5.0-2aae596-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-2aae596.zip

A preview of the website (the last 30 builds are retained):

https://2aae596-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1359/head:pr_1359 && git checkout pr_1359
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-2aae596

* updated log levels in sdkserver * updated log levels in pkg Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from cyriltovena and markmandel February 24, 2020 11:09

google-oss-robot added the size/M label Feb 24, 2020

akremsa requested a review from aLekSer February 24, 2020 11:17

akremsa force-pushed the log-levels branch 2 times, most recently from 744fdd3 to 1b7a331 Compare February 25, 2020 09:55

aLekSer reviewed Feb 25, 2020

View reviewed changes

pkg/sdkserver/localsdk.go Outdated Show resolved Hide resolved

akremsa force-pushed the log-levels branch from 1b7a331 to 76321a0 Compare February 26, 2020 12:24

markmandel reviewed Feb 26, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

markmandel reviewed Feb 26, 2020

View reviewed changes

markmandel added area/operations Installation, updating, metrics etc feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 26, 2020

akremsa force-pushed the log-levels branch from 76321a0 to f656eaf Compare February 27, 2020 09:39

google-oss-robot added size/L and removed size/M labels Feb 27, 2020

akremsa changed the title ~~Updated log levels in sdkserver~~ Updated log levels in pkg Feb 27, 2020

akremsa force-pushed the log-levels branch from 4d78edf to 1c7e777 Compare February 27, 2020 10:06

akremsa force-pushed the log-levels branch from 1c7e777 to 175dc96 Compare February 27, 2020 10:14

akremsa force-pushed the log-levels branch from 175dc96 to 930eb8d Compare February 28, 2020 13:31

akremsa force-pushed the log-levels branch from 930eb8d to 378f9a9 Compare March 2, 2020 09:36

google-oss-robot assigned markmandel Mar 3, 2020

akremsa force-pushed the log-levels branch from 378f9a9 to 97d79f4 Compare March 3, 2020 09:01

akremsa force-pushed the log-levels branch from 97d79f4 to f3c14f4 Compare March 4, 2020 11:57

akremsa force-pushed the log-levels branch from f3c14f4 to 8a7aafe Compare March 4, 2020 12:13

akremsa force-pushed the log-levels branch from 8a7aafe to 0d00320 Compare March 4, 2020 13:08

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Mar 4, 2020

alexey-kremsa-globant added 2 commits March 5, 2020 14:03

updated log levels in sdkserver

aae6006

updated log levels in pkg

751630c

Minor fixes

akremsa force-pushed the log-levels branch from 0d00320 to 751630c Compare March 5, 2020 11:03

aLekSer approved these changes Mar 5, 2020

View reviewed changes

google-oss-robot assigned aLekSer Mar 5, 2020

google-oss-robot added the lgtm label Mar 5, 2020

Merge branch 'master' into log-levels

2aae596

google-oss-robot removed the lgtm label Mar 5, 2020

markmandel merged commit cf3d21d into googleforgames:master Mar 5, 2020

markmandel added this to the 1.5.0 milestone Mar 5, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Updated log levels in pkg (googleforgames#1359)

a74235a

* updated log levels in sdkserver * updated log levels in pkg Co-authored-by: Mark Mandel <markmandel@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated log levels in pkg #1359

Updated log levels in pkg #1359

akremsa commented Feb 24, 2020 •

edited

Loading

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 25, 2020

agones-bot commented Feb 25, 2020

agones-bot commented Feb 26, 2020

markmandel left a comment

agones-bot commented Feb 27, 2020

agones-bot commented Feb 27, 2020

akremsa commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Mar 2, 2020

akremsa commented Mar 3, 2020

agones-bot commented Mar 3, 2020

aLekSer commented Mar 4, 2020 •

edited

Loading

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 5, 2020

google-oss-robot commented Mar 5, 2020

google-oss-robot commented Mar 5, 2020

agones-bot commented Mar 5, 2020

Updated log levels in pkg #1359

Updated log levels in pkg #1359

Conversation

akremsa commented Feb 24, 2020 • edited Loading

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 25, 2020

agones-bot commented Feb 25, 2020

agones-bot commented Feb 26, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 27, 2020

agones-bot commented Feb 27, 2020

akremsa commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Mar 2, 2020

akremsa commented Mar 3, 2020

agones-bot commented Mar 3, 2020

aLekSer commented Mar 4, 2020 • edited Loading

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 5, 2020

google-oss-robot commented Mar 5, 2020

google-oss-robot commented Mar 5, 2020

agones-bot commented Mar 5, 2020

akremsa commented Feb 24, 2020 •

edited

Loading

aLekSer commented Mar 4, 2020 •

edited

Loading