Cleanup of grpc go generation code #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd previously generated this in two places, and looking at it through Godoc, it seemed like a code smell. Having the generated code in a single place seems like the cleaner option.
|
@enocom Curious if you see any issues here? |
|
@markmandel Yeah, definitely don't need two generated files. The C++ generated stuff might even be deleted too. In theory, the proto file is enough, but since we're providing a Go library, we might as well have the generated code for people consuming things within |
|
Personally, I prefer to keep generated files in the repo - makes clear what is going on (the CRD client is all generated too) - as long as it's header'd appropriately. Kinda like vendoring dependencies 😄 |
|
Also makes it go-gettable |
|
Build Succeeded 👏 Build Id: a2980d51-f540-4758-95e6-64c07f487614 The following development artifacts have been built, and will exist for the next 30 days:
|
|
SGTM. Duplicate unnecessary, for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd previously generated this in two places, and looking at it through Godoc, it seemed like a code smell.
Having the generated code in a single place seems like the cleaner option.