Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure due to v1alpha becoming v1. #1361

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix test failure due to v1alpha becoming v1. #1361

merged 1 commit into from
Feb 24, 2020

Conversation

drichardson
Copy link
Contributor

The make test errors being fixed are:

htmltest started at 08:57:46 on /tmp/website
========================================================================
site/docs/advanced/multi-cluster-allocation/index.html
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
========================================================================
✘✘✘ failed in 661.113314ms
2 errors in 99 documents

Testing Done

Run make test.

Before change, failed with 2 errors above. After change, passes with no errors.

@drichardson
Copy link
Contributor Author

/assign @roberthbailey

@drichardson drichardson changed the title Fix test failure due to multicluster/v1alpha becoming multicluster/v1. Fix test failure due to v1alpha becoming v1. Feb 24, 2020
pooneh-m
pooneh-m suggested changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Tracking issue #1333

site/content/en/docs/Advanced/multi-cluster-allocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c1122e0-05c4-4ec7-88d4-9bbcc204e893

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1361/head:pr_1361 && git checkout pr_1361
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e5c2f72

@drichardson
Fix test failure due to v1alpha becoming v1.
403568a 
The make test errors being fixed are:

htmltest started at 08:57:46 on /tmp/website
========================================================================
site/docs/advanced/multi-cluster-allocation/index.html
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
========================================================================
✘✘✘ failed in 661.113314ms
2 errors in 99 documents
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9b36dbf4-91bf-46c6-b88f-24942acbaa05

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1361/head:pr_1361 && git checkout pr_1361
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e86601b

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drichardson, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 113c87f0-8363-4ff0-84c7-fad2021b434a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1361/head:pr_1361 && git checkout pr_1361
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e15294c

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5c1e8d25-7d98-4ad6-9b67-74a622522432

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1361/head:pr_1361 && git checkout pr_1361
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-403568a

@pooneh-m pooneh-m merged commit 3abf63b into googleforgames:master Feb 24, 2020
@drichardson drichardson deleted the fix_html_test_failure branch February 24, 2020 21:46
@drichardson drichardson restored the fix_html_test_failure branch February 24, 2020 21:49
drichardson
drichardson commented Feb 24, 2020
View reviewed changes
site/content/en/docs/Advanced/multi-cluster-allocation.md
@@ -96,7 +96,7 @@ To enable multi-cluster allocation, set `multiClusterSetting.enabled` to `true`
NAMESPACE=<namespace>
FLEET_NAME=<fleet name>

curl https://${EXTERNAL_IP}:443/v1alpha1/gameserverallocation \
curl https://${EXTERNAL_IP}:443/v1alpha/gameserverallocation \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooneh-m Uh oh, I screwed up here. I meant to revert back to v1alpha1 but used v1alpha instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. I'll fix it with my change.

drichardson
drichardson commented Feb 24, 2020
View reviewed changes
site/content/en/docs/Advanced/multi-cluster-allocation.md

In the following example the policy is defined for cluster B in cluster A.

```bash
cat <<EOF | kubectl apply -f -
apiVersion: multicluster.agones.dev/v1alpha1
apiVersion: multicluster.agones.dev/v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also screwed this up. Meant to revert.

Copy link
Contributor

@pooneh-m pooneh-m Feb 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 is correct

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 24, 2020
@drichardson drichardson mentioned this pull request Feb 25, 2020
Closed
@drichardson drichardson deleted the fix_html_test_failure branch February 25, 2020 20:14
@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. labels Feb 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@drichardson @ilkercelikyilmaz
Fix test failure due to v1alpha becoming v1. (googleforgames#1361)
20c5dca 
The make test errors being fixed are:

htmltest started at 08:57:46 on /tmp/website
========================================================================
site/docs/advanced/multi-cluster-allocation/index.html
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
========================================================================
✘✘✘ failed in 661.113314ms
2 errors in 99 documents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@roberthbailey roberthbailey

@pooneh-m pooneh-m

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@drichardson @agones-bot @google-oss-robot @pooneh-m @markmandel @roberthbailey