Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.4.0 Release Candidate #1367

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Release 1.4.0 Release Candidate #1367

merged 1 commit into from
Feb 26, 2020

Conversation

markmandel
Copy link
Member

No description provided.

@markmandel markmandel added the kind/release Checklist for a release label Feb 26, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b761ab7e-7d3a-4943-a9cb-c6b47246334f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1367/head:pr_1367 && git checkout pr_1367
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-0de4cab

@google-oss-robot
Copy link

@drichardson: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drichardson, markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel merged commit 3472f0a into master Feb 26, 2020
pooneh-m
pooneh-m reviewed Feb 26, 2020
View reviewed changes
CHANGELOG.md

**Implemented enhancements:**

- Change GameServerAllocationPolicy CRD version to stable [\#1290](https://github.com/googleforgames/agones/issues/1290)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This perhaps should not be here? it is mentioned in the Breaking change section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the breaking tag to the issue, so it will move in the Changelog when we regen for the stable release. 👍

@markmandel markmandel deleted the release/1.4.0-rc branch February 26, 2020 21:43
aLekSer
aLekSer reviewed Feb 26, 2020
View reviewed changes
docs/governance/templates/release.md
@@ -27,6 +27,7 @@ Images available with this release:
- [gcr.io/agones-images/udp-server:{example-version}](https://gcr.io/agones-images/udp-server:{example-version})
- [gcr.io/agones-images/tcp-server:{example-version}](https://gcr.io/agones-images/tcp-server:{example-version})
- [gcr.io/agones-images/xonotic-example:{example-version}](https://gcr.io/agones-images/xonotic-example:{example-version})
- [gcr.io/agones-images/supertuxkart-example:{example-version}](https://gcr.io/agones-images/supertuxkart-example:{example-version})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an option to add gcr.io/agones-images/crd-client:0.1

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Release 1.4.0 Release Candidate (googleforgames#1367)
a4117a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@aLekSer aLekSer aLekSer left review comments

@drichardson drichardson drichardson approved these changes

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

Assignees

@pooneh-m pooneh-m

Labels
approved kind/release Checklist for a release lgtm size/L
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@markmandel @agones-bot @google-oss-robot @drichardson @aLekSer @pooneh-m