Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform EKS module to 1.14 version #1386

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Update terraform EKS module to 1.14 version #1386

merged 2 commits into from
Mar 5, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Mar 4, 2020 •
edited
Loading

Sync up with documentation in Creating cluster.

https://development.agones.dev/site/docs/installation/creating-cluster/eks/

Sync up terraform patch version to be consistent with build base image.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b28fc88f-a995-424e-bdc8-1c31547be6f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Update terraform EKS module to 1.14 version
d819185 
Sync up with documentation in `Creating cluster`.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 091b144b-16ea-4632-830a-41ff949d7325

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1386/head:pr_1386 && git checkout pr_1386
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-d819185

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm labels Mar 5, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6fbbb600-6343-4246-a97b-618c74eeab33

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1386/head:pr_1386 && git checkout pr_1386
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-1902cc8

@markmandel markmandel merged commit a172102 into googleforgames:master Mar 5, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Update terraform EKS module to 1.14 version (googleforgames#1386)
5c05680 
Sync up with documentation in `Creating cluster`.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel