SdkServer: updateState does not do a DeepClone()

[markmandel]

This might be the reason for TestGameServerReserve's flakiness.

Either way, this is worth fixing, to ensure that the backing Kubernetes client cache for the sdk server is not corrupted and cause indeterminate behaviour.

[agones-bot]

Build Succeeded 👏

Build Id: dbb9c5c8-aef9-49f6-b2ef-7d27916bed28

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.5.0-2fe235c
• image: gcr.io/agones-images/agones-sdk:1.5.0-2fe235c
• image: gcr.io/agones-images/agones-ping:1.5.0-2fe235c
• Linux C++ SDK (build): agonessdk-1.5.0-2fe235c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.5.0-2fe235c.zip

A preview of the website (the last 30 builds are retained):

• https://2fe235c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1398/head:pr_1398 && git checkout pr_1398
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-2fe235c

[cyriltovena]

LGTM

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, cyriltovena, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cyriltovena,markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: d1dd34be-62a3-4eaa-a88c-1ca5b083017d

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: ec996de0-c23d-4c52-8e82-a3f29eabd8db

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Still failed.

--- FAIL: TestGameServerReserve (124.40s)
gameserver_test.go:499:
Error Trace: gameserver_test.go:499
Error: Received unexpected error:
timed out waiting for the condition
waiting for GameServer to be Reserved default/udp-serverv5tcm
agones.dev/agones/test/e2e/framework.(*Framework).WaitForGameServerStateWithLogger
/go/src/agones.dev/agones/test/e2e/framework/framework.go:166
agones.dev/agones/test/e2e.TestGameServerReserve
/go/src/agones.dev/agones/test/e2e/gameserver_test.go:498
testing.tRunner
/usr/local/go/src/testing/testing.go:909
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1357
Test: TestGameServerReserve
Messages: GameServer Name: udp-serverv5tcm
gameserver_test.go:500:
Error Trace: gameserver_test.go:500
Error: Not equal:
expected: "Reserved"
actual : "Ready"

    	            	Diff:
    	            	--- Expected
    	            	+++ Actual
    	            	@@ -1,2 +1,2 @@
    	            	-(v1.GameServerState) (len=8) "Reserved"
    	            	+(v1.GameServerState) (len=5) "Ready"
    	            	 
    	Test:       	TestGameServerReserve
    	Messages:   	GameServer Name: udp-serverv5tcm

Oh well, still a good thing to have.

[agones-bot]

Build Failed 😱

Build Id: a91e3661-07ff-4cd4-9e6d-87f19e948072

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 7d3da9f7-b93a-4522-b48c-f8ce09f1e2e4

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.5.0-df79b75
• image: gcr.io/agones-images/agones-sdk:1.5.0-df79b75
• image: gcr.io/agones-images/agones-ping:1.5.0-df79b75
• Linux C++ SDK (build): agonessdk-1.5.0-df79b75-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.5.0-df79b75.zip

A preview of the website (the last 30 builds are retained):

• https://df79b75-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1398/head:pr_1398 && git checkout pr_1398
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-df79b75

[agones-bot]

Build Failed 😱

Build Id: d2bcab4d-2cd3-477a-965d-a35daf929922

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 96e5960f-33e5-4795-942d-42e83f6652eb

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.5.0-98037d2
• image: gcr.io/agones-images/agones-sdk:1.5.0-98037d2
• image: gcr.io/agones-images/agones-ping:1.5.0-98037d2
• Linux C++ SDK (build): agonessdk-1.5.0-98037d2-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.5.0-98037d2.zip

A preview of the website (the last 30 builds are retained):

• https://98037d2-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1398/head:pr_1398 && git checkout pr_1398
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-98037d2