-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ErrorHandling for failed to create pods because of forbidden #1400
Conversation
Fixed so that put the reason of forbidden error to Event and STATE change to "Error".
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/assign @pooneh-m |
Build Succeeded 👏 Build Id: 8d72118a-e44d-48f7-866b-e18b5bf72794 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!! Thanks @suecideTech for the change. It is useful with the permission debugging.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pooneh-m, suecideTech The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…gleforgames#1400) Fixed so that put the reason of forbidden error to Event and STATE change to "Error".
When failed to create GameServer Pods becouse of "forbidden", GameServer's STATE remained "Creating".
eg. agones-sdk serviceaccount does not exist
Fixed so that put the reason of error to Event and STATE change to "Error".
Test results
Closes #1370