update client-go for kubernetes-1.14.10 #1404

heartrobotninja · 2020-03-10T06:32:50Z

Update client-go
Remove vendor-fixes 🎉
Fix metric definitions to coincide with client-go update.

heartrobotninja · 2020-03-10T06:33:49Z

/assign @roberthbailey

agones-bot · 2020-03-10T06:49:34Z

Build Succeeded 👏

Build Id: 80a4caf9-f10f-43f0-8a24-c8bdd5e871d8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-3e9858f
image: gcr.io/agones-images/agones-sdk:1.5.0-3e9858f
image: gcr.io/agones-images/agones-ping:1.5.0-3e9858f
Linux C++ SDK (build): agonessdk-1.5.0-3e9858f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-3e9858f.zip

A preview of the website (the last 30 builds are retained):

https://3e9858f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1404/head:pr_1404 && git checkout pr_1404
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-3e9858f

aLekSer · 2020-03-10T20:01:02Z

Thanks for this update!

I have just noticed when I do go mod tidy on your changes:

git diff                                                                                                                                                           
diff --git a/go.mod b/go.mod
index 149ac454..5557f2b3 100644
--- a/go.mod
+++ b/go.mod
@@ -36,11 +36,11 @@ require (
        github.com/stretchr/testify v1.3.0
        go.opencensus.io v0.18.0
        golang.org/x/net v0.0.0-20190311183353-d8887717615a
+       golang.org/x/oauth2 v0.0.0-20181203162652-d668ce993890
        golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4 // indirect
        golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2
        golang.org/x/tools v0.0.0-20190328211700-ab21143f2384
        google.golang.org/api v0.0.0-20190117000611-43037ff31f69 // indirect
-       google.golang.org/appengine v1.4.0 // indirect
        google.golang.org/genproto v0.0.0-20191009194640-548a555dbc03
        google.golang.org/grpc v1.20.1
        gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.0 // indirect

Let me know if someone also see this. Could be issue with my local setup.
go mod vendor also removes some files.

        modified:   go.mod                                                                                                                                                                               
        deleted:    vendor/golang.org/x/sys/unix/mkasm_darwin.go                                                                                                                                         
        deleted:    vendor/golang.org/x/sys/unix/mkpost.go                                                                                                                                               
        deleted:    vendor/golang.org/x/sys/unix/mksyscall.go                                                                                                                                            
        deleted:    vendor/golang.org/x/sys/unix/mksyscall_aix_ppc.go
        deleted:    vendor/golang.org/x/sys/unix/mksyscall_aix_ppc64.go

heartrobotninja · 2020-03-10T20:27:58Z

I have done go clean -modcache; go mod tidy; go mod verify; and go mod vendor and I am not seeing the same diff, here is my go.mod file:

module agones.dev/agones

go 1.13

require (
        cloud.google.com/go v0.34.0
        contrib.go.opencensus.io/exporter/stackdriver v0.8.0
        fortio.org/fortio v1.3.1
        github.com/ahmetb/gen-crd-api-reference-docs v0.1.1
        github.com/aws/aws-sdk-go v1.16.20 // indirect
        github.com/evanphx/json-patch v4.5.0+incompatible // indirect
        github.com/fsnotify/fsnotify v1.4.7
        github.com/go-openapi/spec v0.19.0
        github.com/gogo/protobuf v1.2.1 // indirect
        github.com/golang/groupcache v0.0.0-20171101203131-84a468cf14b4 // indirect
        github.com/golang/protobuf v1.3.2
        github.com/google/gofuzz v1.0.0 // indirect
        github.com/google/uuid v1.1.0 // indirect
        github.com/googleapis/gnostic v0.1.0 // indirect
        github.com/grpc-ecosystem/grpc-gateway v1.11.3
        github.com/hashicorp/golang-lru v0.5.1 // indirect
        github.com/heptiolabs/healthcheck v0.0.0-20171201210846-da5fdee475fb
        github.com/imdario/mergo v0.3.5 // indirect
        github.com/joonix/log v0.0.0-20180502111528-d2d3f2f4a806
        github.com/json-iterator/go v1.1.5 // indirect
        github.com/mattbaird/jsonpatch v0.0.0-20171005235357-81af80346b1a
        github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d
        github.com/onsi/ginkgo v1.8.0 // indirect
        github.com/onsi/gomega v1.5.0 // indirect
        github.com/pborman/uuid v1.2.0 // indirect
        github.com/pkg/errors v0.8.1
        github.com/prometheus/client_golang v0.9.2
        github.com/sirupsen/logrus v1.2.0
        github.com/spf13/pflag v1.0.3
        github.com/spf13/viper v1.3.1
        github.com/stretchr/testify v1.3.0
        go.opencensus.io v0.18.0
        golang.org/x/net v0.0.0-20190311183353-d8887717615a
        golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4 // indirect
        golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2
        golang.org/x/tools v0.0.0-20190328211700-ab21143f2384
        google.golang.org/api v0.0.0-20190117000611-43037ff31f69 // indirect
        google.golang.org/appengine v1.4.0 // indirect
        google.golang.org/genproto v0.0.0-20191009194640-548a555dbc03
        google.golang.org/grpc v1.20.1
        gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.0 // indirect
        gopkg.in/fsnotify.v1 v1.4.7
        gopkg.in/inf.v0 v0.9.1 // indirect
        gopkg.in/natefinch/lumberjack.v2 v2.0.0-20170531160350-a96e63847dc3
        gopkg.in/yaml.v2 v2.2.2
        k8s.io/api v0.0.0-20191004102349-159aefb8556b // kubernetes-1.14.10
        k8s.io/apiextensions-apiserver v0.0.0-20191212015246-8fe0c124fb40 // kubernetes-1.14.10
        k8s.io/apimachinery v0.0.0-20191004074956-c5d2f014d689 // kubernetes-1.14.10
        k8s.io/client-go v11.0.1-0.20191029005444-8e4128053008+incompatible // kubernetes-1.14.10
        k8s.io/kube-openapi v0.0.0-20190709113604-33be087ad058 // indirect
        k8s.io/utils v0.0.0-20200124190032-861946025e34 // indirect
        sigs.k8s.io/yaml v1.1.0 // indirect
)

heartrobotninja · 2020-03-10T22:34:05Z

@aLekSer I am not sure what is causing the difference. Did you have changes in the client you did the diff from?

aLekSer · 2020-03-11T05:20:52Z

@heartrobotninja I will double check this on a clean environment (fresh clone)

aLekSer · 2020-03-11T07:02:46Z

This might be related to this ticket:
golang/go#33151
I am using go 1.13.3
Also there is an option to perform go mod tidy from make shell to have equivalent golang versions (go1.13.5 linux/amd64 in make shell).

steven-supersolid · 2020-03-12T14:22:28Z

sdks/nodejs/package-lock.json

@@ -1,6 +1,6 @@
 {
  "name": "@google-cloud/agones-sdk",
-  "version": "1.3.0",


@markmandel We may need to add a step to the process for publishing to prevent this file getting modified later as seen here and in other reviews. Here's what we do internally:

Increment version in package.json

Run npm i which will also update package-lock.json

Run npm publish

I think we should revert the changes to this file in this PR and update nodejs dependencies independently of client-go dependencies.

roberthbailey · 2020-03-16T17:39:04Z

/assign @aLekSer

roberthbailey · 2020-03-16T17:46:16Z

@heartrobotninja - I took a look and other than the comment from @steven-supersolid I think we just need to resolve the delta between what you and @aLekSer are seeing in go.mod to get this merged.

aLekSer · 2020-03-16T20:00:11Z

I found an issue that caused part of the diff:

go mod why -m golang.org/x/oauth2
# golang.org/x/oauth2
agones.dev/agones/test/sdk/restapi/swagger
golang.org/x/oauth2

make clean-sdk-conformance-tests helped to resolve this issue.

This line only left:

-       google.golang.org/appengine v1.4.0 // indirect

aLekSer · 2020-03-16T20:39:18Z

@heartrobotninja I approve all other changes, but go.mod should be updated.
I assume you are using a Go version less than in base build image (1.12? ). In order to fix this discrepancy you can run go mod tidy command from make shell, or install version 1.13.5 or latest.

$ gvm use go1.13
Now using version go1.13
$ go mod tidy
git diff
diff --git a/go.mod b/go.mod
index 149ac454..6f643772 100644
--- a/go.mod
+++ b/go.mod
@@ -40,7 +40,6 @@ require (
        golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2
        golang.org/x/tools v0.0.0-20190328211700-ab21143f2384
        google.golang.org/api v0.0.0-20190117000611-43037ff31f69 // indirect
-       google.golang.org/appengine v1.4.0 // indirect
        google.golang.org/genproto v0.0.0-20191009194640-548a555dbc03
        google.golang.org/grpc v1.20.1
        gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.0 // indirect
$ gvm use go1.12
Now using version go1.12
$ go mod tidy
$ git diff | wc -l
0

heartrobotninja · 2020-03-17T00:22:54Z

Ok it turns out I was using go-1.12.4. Updated and re-ran go mod tidy/verify/vendor and rebased on most current googleforgames/agones master.

agones-bot · 2020-03-17T00:35:13Z

Build Failed 😱

Build Id: 2cfc90ba-a25b-4001-a21a-d0c7e5ab4cdc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer

Thanks @heartrobotninja now we would not have issues with vendor_fixes.

roberthbailey · 2020-03-17T14:47:59Z

--- FAIL: TestGameServerReserve (119.09s)
    gameserver_test.go:499: 
        	Error Trace:	gameserver_test.go:499
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	            	waiting for GameServer to be Reserved default/udp-server2d6dl
        	            	agones.dev/agones/test/e2e/framework.(*Framework).WaitForGameServerStateWithLogger
        	            		/go/src/agones.dev/agones/test/e2e/framework/framework.go:166
        	            	agones.dev/agones/test/e2e.TestGameServerReserve
        	            		/go/src/agones.dev/agones/test/e2e/gameserver_test.go:498
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:909
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1357
        	Test:       	TestGameServerReserve
        	Messages:   	GameServer Name: udp-server2d6dl
    gameserver_test.go:500: 
        	Error Trace:	gameserver_test.go:500
        	Error:      	Not equal: 
        	            	expected: "Reserved"
        	            	actual  : "Ready"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(v1.GameServerState) (len=8) "Reserved"
        	            	+(v1.GameServerState) (len=5) "Ready"
        	            	 
        	Test:       	TestGameServerReserve
        	Messages:   	GameServer Name: udp-server2d6dl

roberthbailey · 2020-03-17T14:48:23Z

I'm going to re-run the test to see if this is a flake or not.

agones-bot · 2020-03-17T15:04:07Z

Build Succeeded 👏

Build Id: a4be0fed-b8d5-4a5d-8427-bf091ca2000f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-d724ae6
image: gcr.io/agones-images/agones-sdk:1.5.0-d724ae6
image: gcr.io/agones-images/agones-ping:1.5.0-d724ae6
Linux C++ SDK (build): agonessdk-1.5.0-d724ae6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-d724ae6.zip

A preview of the website (the last 30 builds are retained):

https://d724ae6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1404/head:pr_1404 && git checkout pr_1404
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-d724ae6

google-oss-robot · 2020-03-17T15:09:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, heartrobotninja, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roberthbailey · 2020-03-26T16:44:06Z

xref #1329

* update client-go for kubernetes-1.14.10 * Update go.mod using go 1.13.8

google-oss-robot requested review from markmandel and steven-supersolid March 10, 2020 06:32

google-oss-robot added the size/XXL label Mar 10, 2020

google-oss-robot assigned roberthbailey Mar 10, 2020

steven-supersolid reviewed Mar 12, 2020

View reviewed changes

google-oss-robot assigned aLekSer Mar 16, 2020

heartrobotninja added 2 commits March 16, 2020 17:16

update client-go for kubernetes-1.14.10

e8409f4

Update go.mod using go 1.13.8

d724ae6

aLekSer approved these changes Mar 17, 2020

View reviewed changes

google-oss-robot added the lgtm label Mar 17, 2020

roberthbailey approved these changes Mar 17, 2020

View reviewed changes

google-oss-robot added the approved label Mar 17, 2020

roberthbailey merged commit af20b4e into googleforgames:master Mar 17, 2020

roberthbailey mentioned this pull request Mar 26, 2020

Upgrade to Kubernetes 1.14 #1329

Closed

29 tasks

markmandel added this to the 1.5.0 milestone Apr 7, 2020

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 7, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

update client-go for kubernetes-1.14.10 (googleforgames#1404)

c2fb48f

* update client-go for kubernetes-1.14.10 * Update go.mod using go 1.13.8

WontonSam mentioned this pull request Sep 23, 2023

[Snyk] Upgrade terser from 5.1.0 to 5.19.3 WontonSam/Phiahplay-#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update client-go for kubernetes-1.14.10 #1404

update client-go for kubernetes-1.14.10 #1404

heartrobotninja commented Mar 10, 2020

heartrobotninja commented Mar 10, 2020

agones-bot commented Mar 10, 2020

aLekSer commented Mar 10, 2020 •

edited

Loading

heartrobotninja commented Mar 10, 2020

heartrobotninja commented Mar 10, 2020

aLekSer commented Mar 11, 2020

aLekSer commented Mar 11, 2020 •

edited

Loading

steven-supersolid Mar 12, 2020

roberthbailey Mar 16, 2020

roberthbailey commented Mar 16, 2020

roberthbailey commented Mar 16, 2020

aLekSer commented Mar 16, 2020 •

edited

Loading

aLekSer commented Mar 16, 2020 •

edited

Loading

heartrobotninja commented Mar 17, 2020

agones-bot commented Mar 17, 2020

aLekSer left a comment

roberthbailey commented Mar 17, 2020

roberthbailey commented Mar 17, 2020

agones-bot commented Mar 17, 2020

google-oss-robot commented Mar 17, 2020

roberthbailey commented Mar 26, 2020

update client-go for kubernetes-1.14.10 #1404

update client-go for kubernetes-1.14.10 #1404

Conversation

heartrobotninja commented Mar 10, 2020

heartrobotninja commented Mar 10, 2020

agones-bot commented Mar 10, 2020

aLekSer commented Mar 10, 2020 • edited Loading

heartrobotninja commented Mar 10, 2020

heartrobotninja commented Mar 10, 2020

aLekSer commented Mar 11, 2020

aLekSer commented Mar 11, 2020 • edited Loading

steven-supersolid Mar 12, 2020

Choose a reason for hiding this comment

roberthbailey Mar 16, 2020

Choose a reason for hiding this comment

roberthbailey commented Mar 16, 2020

roberthbailey commented Mar 16, 2020

aLekSer commented Mar 16, 2020 • edited Loading

aLekSer commented Mar 16, 2020 • edited Loading

heartrobotninja commented Mar 17, 2020

agones-bot commented Mar 17, 2020

aLekSer left a comment

Choose a reason for hiding this comment

roberthbailey commented Mar 17, 2020

roberthbailey commented Mar 17, 2020

agones-bot commented Mar 17, 2020

google-oss-robot commented Mar 17, 2020

roberthbailey commented Mar 26, 2020

aLekSer commented Mar 10, 2020 •

edited

Loading

aLekSer commented Mar 11, 2020 •

edited

Loading

aLekSer commented Mar 16, 2020 •

edited

Loading

aLekSer commented Mar 16, 2020 •

edited

Loading