Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing allocator affinity and tolerations to helm docs #1406

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Add missing allocator affinity and tolerations to helm docs #1406

merged 2 commits into from
Mar 16, 2020

Conversation

bburghaus
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d67e524f-3b0b-44ef-b2f1-bc64adb004f2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1406/head:pr_1406 && git checkout pr_1406
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-bb7f674

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cdca044b-0a21-4efe-80ce-17fd3a121a2f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1406/head:pr_1406 && git checkout pr_1406
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-f6ea735

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fedd920a-4190-4d7b-8406-b6b93e619550

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@bburghaus
Copy link
Contributor Author

/assign @EricFortin

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for the addition!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bburghaus, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a92e7ddc-64cb-436b-9795-0a3754bdd150

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1406/head:pr_1406 && git checkout pr_1406
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-9e833bb

@markmandel markmandel merged commit aee4e78 into googleforgames:master Mar 16, 2020
@markmandel markmandel added this to the 1.5.0 milestone Mar 16, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Mar 16, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants