Flaky: TestGameServerReserve #1412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea behind this solution is that as you get down into the WaitFor() commands, there is a goroutine that is run to implement polling. Normally, if there is a delay due to goroutine scheduling, this is fine, as we are waiting for something to happen, and if the test comes in after the thing happened - then that is fine. In this instance, we definitely need to check right away, so I implemented a special case of using a for loop instead, so that the test can't be non-determinately delayed.
markmandel
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 3575b80c-e2c3-4941-bf80-b296b5abb174 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: a67a5001-cda8-4241-961a-0536234f0552 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: ab62a331-9594-468d-8e93-5e4b0c504f0e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 5afce8ac-4dbc-4f73-bf0a-c5d41469fbf8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Failed 😱 Build Id: c4c50efe-3436-42d6-b367-1005e41bca6c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Different flake - TestControllerRunCacheSync in the unit tests. |
|
Build Succeeded 👏 Build Id: 6015d478-d0f6-4024-bc25-27bfd6355ad3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Failed 😱 Build Id: e017ae58-7a57-4f02-a4a4-62eb6776bb91 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Failure on different flake - TestUnhealthyGameServersWithoutFreePorts |
|
Build Failed 😱 Build Id: be902966-192a-4df1-a6b0-e52791e0910e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
I thought I had solved this, but nope - check this out. |
The idea behind this solution is that as you get down into the WaitFor() commands, there is a goroutine that is run to implement polling.
Normally, if there is a delay due to goroutine scheduling, this is fine, as we are waiting for something to happen, and if the test comes in after the thing happened - then that is fine.
In this instance, we definitely need to check right away, so I implemented a special case of using a for loop instead, so that the test can't be non-determinately delayed.