Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version to stress tests files #1433

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Mar 26, 2020

Part of #573

Added version number to stress tests file names and to Labels field.

Tests output file looks like this:
stress_1_fleet_10_scale_down_1.5.0-0607041_2020-03-26_1424.json

Labels field:
"Labels": "Agones stress_1_fleet_10_scale_up_1.5.0-0607041"

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1ce6d683-7a6c-4037-8af0-f5c54be78b69

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Mar 26, 2020

E2E test has failed:

time="2020-03-26 15:11:39.376" level=info msg="fleet simple-fleet-7gl2g has 0/3 ready replicas"
time="2020-03-26 15:11:39.278" level=info msg="waiting for fleet condition" fleet=simple-fleet-7gl2g
    allocator_test.go:61: deleting pods failed: pods "agones-allocator-765ccc4685-6gjjv" not found
--- FAIL: TestAllocator (1.99s)
time="2020-03-26 15:11:31.916" level=info msg="Finished cleanup."

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 39d0b92c-52bc-4d67-b8f4-945903fc0986

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1433/head:pr_1433 && git checkout pr_1433
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-58b96ff

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e0fc42ce-e4ef-49ba-8cbc-7d3eb5685d92

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1433/head:pr_1433 && git checkout pr_1433
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-fd97369

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 66309362-e1bc-4543-b3ea-211cc6892004

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 18d4e3d9-5e3e-4db8-a8b8-81a075e85149

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1e4f5574-a056-43b8-80bb-0637f6930cb9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1433/head:pr_1433 && git checkout pr_1433
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-55ae490

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eaee816a-cc36-47c0-bd86-61000b52dabd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@@ -115,6 +116,7 @@ func NewFromFlags() (*Framework, error) {
"optional secret to be used for pulling the gameserver and/or Agones SDK sidecar images")
stressTestLevel := flag.Int("stress", 0, "enable stress test at given level 0-100")
perfOutputDir := flag.String("perf-output", "", "write performance statistics to the specified directory")
version := flag.String("version", "", "agones controller version that was tested in the release version plus the short hash of the latest commit")
Copy link
Collaborator

@aLekSer aLekSer Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version := flag.String("version", "", "agones controller version that was tested in the release version plus the short hash of the latest commit")
version := flag.String("version", "", "agones controller version to be tested, consists of release version plus the short hash of the latest commit")

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 541f8cd2-ea51-4959-a1c3-8f61ce1015e5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1433/head:pr_1433 && git checkout pr_1433
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-2d1ef0f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eda28c96-2c9f-4923-9ecc-f1f731e566dc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1433/head:pr_1433 && git checkout pr_1433
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-9f6d325

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged. This change is needed to automate Stress Tests on different versions of Agones and later share resulted JSON with Fortio UI server.
Part of #573 .

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign markmandel
You can assign the PR to them by writing /assign @markmandel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 44bd71f into googleforgames:master Apr 2, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Apr 7, 2020
@markmandel markmandel added the kind/feature New features for Agones label Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* Added version to stress tests files


fix

* version flag description update

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants