Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong function usage #1442

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Fix wrong function usage #1442

merged 2 commits into from
Apr 2, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Apr 1, 2020

Log error properly when Controller started with wrong parameters.

@aLekSer
Fix wrong function usage
a19150f 
Log error properly when Controller started with wrong parameters.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 92f8947c-7a79-4dda-88fb-2d9cd5f47a22

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1442/head:pr_1442 && git checkout pr_1442
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-a19150f

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f4dc9fe7-72d7-4d00-be47-2a740587f4e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1442/head:pr_1442 && git checkout pr_1442
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-c9ab0bd

@roberthbailey roberthbailey merged commit ec9400a into googleforgames:master Apr 2, 2020
@aLekSer aLekSer deleted the fix/wrong-func-call branch April 2, 2020 10:23
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @roberthbailey @ilkercelikyilmaz
Fix wrong function usage (googleforgames#1442)
959c18d 
Log error properly when Controller started with wrong parameters.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel