Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local implementation of Set/GetPlayerCapacity #1444

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Local implementation of Set/GetPlayerCapacity #1444

merged 1 commit into from
Apr 4, 2020

Conversation

markmandel
Copy link
Member

Local SDK implementations of SetPlayerCapacity and GetPlayerCapacity,
including conformance tests for the Go SDK.

Work on #1033

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Apr 2, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 494d55af-d6ca-4302-baec-e1ebbeda4a05

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the feature/player-capacity-local branch from c5039c1 to 330c9e5 Compare April 2, 2020 02:55
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 924fd44b-1e8c-45ec-980d-43c620763714

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1444/head:pr_1444 && git checkout pr_1444
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-330c9e5

@markmandel markmandel requested review from roberthbailey and pooneh-m and removed request for cyriltovena and EricFortin April 2, 2020 03:18
roberthbailey
roberthbailey reviewed Apr 2, 2020
View reviewed changes
build/includes/sdk.mk Outdated Show resolved Hide resolved
test/sdk/go/sdk-client-test.go Outdated Show resolved Hide resolved
@roberthbailey roberthbailey self-assigned this Apr 2, 2020
@markmandel
Local implementation of Set/GetPlayerCapacity
92de6a7 
Local SDK implementations of SetPlayerCapacity and GetPlayerCapacity,
including conformance tests for the Go SDK.

Work on googleforgames#1033
@markmandel markmandel force-pushed the feature/player-capacity-local branch from 330c9e5 to 92de6a7 Compare April 2, 2020 16:31
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4e8f1dac-fc04-42fd-836c-fac835a82298

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1444/head:pr_1444 && git checkout pr_1444
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-92de6a7

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit b5be5fc into googleforgames:master Apr 4, 2020
@markmandel markmandel deleted the feature/player-capacity-local branch April 4, 2020 04:15
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Local implementation of Set/GetPlayerCapacity (googleforgames#1444)
b51253f 
Local SDK implementations of SetPlayerCapacity and GetPlayerCapacity,
including conformance tests for the Go SDK.

Work on googleforgames#1033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey