Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestLocalSDKServerPlayerCapacity #1451

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Flaky: TestLocalSDKServerPlayerCapacity #1451

merged 2 commits into from
Apr 6, 2020

Conversation

markmandel
Copy link
Member

Go routine could fire after we run the method that fires
the watched event, so let's wait until we know watching is
actively working.

@markmandel
Flaky: TestLocalSDKServerPlayerCapacity
e05f863 
Go routine could fire after we run the method that fires
the watched event, so let's wait until we know watching is
actively working.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Apr 6, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c0f59ab8-124f-4128-9d63-9a4a0abfa20e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member Author

SDK Conformance flakiness 😞

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 309432a8-a2c6-4f45-95f3-8801af9f04da

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7b7e01eb-11ea-40aa-b8e5-aadb9f93230e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1451/head:pr_1451 && git checkout pr_1451
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-aa60d2a

@markmandel markmandel merged commit a8ffcb8 into googleforgames:master Apr 6, 2020
@markmandel markmandel deleted the flaky/TestLocalSDKServerPlayerCapacity branch April 6, 2020 19:55
@markmandel markmandel added this to the 1.5.0 milestone Apr 6, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Flaky: TestLocalSDKServerPlayerCapacity (googleforgames#1451)
9b9dd8c 
Go routine could fire after we run the method that fires
the watched event, so let's wait until we know watching is
actively working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. size/S
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey