Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working Node.js example gameserver.yaml #1469

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Working Node.js example gameserver.yaml #1469

merged 1 commit into from
Apr 14, 2020

Conversation

markmandel
Copy link
Member

Was testing out the node.js example in attempt to replicate #1299, but
needed to make changes to the gameserver.yaml to make sure it worked
correctly.

@markmandel markmandel added kind/bug These are bugs. area/examples Examples. Usually found in the `examples` directory labels Apr 14, 2020
@markmandel markmandel requested a review from aLekSer April 14, 2020 01:15
@markmandel markmandel removed the request for review from cyriltovena April 14, 2020 01:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0b45eef8-1942-4bed-aaf9-d07461c95fef

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1469/head:pr_1469 && git checkout pr_1469
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-eb2fc42

@markmandel markmandel mentioned this pull request Apr 14, 2020
Closed
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ca58450b-631d-41c4-9b4a-99335b064624

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1469/head:pr_1469 && git checkout pr_1469
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-33fae7a

@markmandel
Working Node.js example gameserver.yaml
bcd07c6 
Was testing out the node.js example in attempt to replicate googleforgames#1299, but
needed to make changes to the gameserver.yaml to make sure it worked
correctly.
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4c0ac78b-82ce-4777-a137-8ac57a37ab78

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1469/head:pr_1469 && git checkout pr_1469
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-bcd07c6

@roberthbailey roberthbailey merged commit 4e70e16 into googleforgames:master Apr 14, 2020
@markmandel markmandel deleted the bug/nodejs-gameserver.yaml branch April 14, 2020 18:28
@markmandel markmandel added this to the 1.5.0 milestone Apr 14, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Working Node.js example gameserver.yaml (googleforgames#1469)
a31720f 
Was testing out the node.js example in attempt to replicate googleforgames#1299, but
needed to make changes to the gameserver.yaml to make sure it worked
correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-supersolid steven-supersolid steven-supersolid approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m pooneh-m approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@steven-supersolid steven-supersolid

@roberthbailey roberthbailey

@pooneh-m pooneh-m

Labels
approved area/examples Examples. Usually found in the `examples` directory kind/bug These are bugs. lgtm size/XS
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@markmandel @agones-bot @google-oss-robot @steven-supersolid @roberthbailey @pooneh-m