Monitoring: fix error on Stackdriver exporter #1479

aLekSer · 2020-04-17T14:24:54Z

Zero value cannot be used as the only value for view.Distribution().

aLekSer · 2020-04-17T14:26:14Z

Also found some useful examples. First uses new version of client-go, so we will need to update metrics with update to 1.15:
https://github.com/knative/pkg/blob/3c828cf99f67f8066e956490f634ebe90abd6892/metrics/reflector_test.go
Example of how distribution could be created:
https://github.com/knative/pkg/blob/4e57475bc87c1aba3e7fcc0207b593dc7186eb83/metrics/workqueue.go#L78
Will add screenshots from Grafana and move to Ready to Review state.
Stackdriver exporter works without errors now. simple-udp with 2 GameServers, Count by Status:

Ready=2
Scheduled=0

agones-bot · 2020-04-17T14:41:30Z

Build Succeeded 👏

Build Id: 10ea39d5-e1f9-4b29-88b9-eacb388bc306

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-df9fe2b
image: gcr.io/agones-images/agones-sdk:1.6.0-df9fe2b
image: gcr.io/agones-images/agones-ping:1.6.0-df9fe2b
Linux C++ SDK (build): agonessdk-1.6.0-df9fe2b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-df9fe2b.zip

A preview of the website (the last 30 builds are retained):

https://df9fe2b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1479/head:pr_1479 && git checkout pr_1479
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-df9fe2b

aLekSer · 2020-04-22T20:32:02Z

On Grafana Workerqueue metrics, I have changed looks the same as before.

However I got a strange issue on GameServers dashboard, that could be caused by Grafana update:

Dashboard init (failed)
Failed create dashboard model
undefined is not iterable (cannot read property Symbol(Symbol.iterator))

agones-bot · 2020-04-23T11:41:30Z

Build Succeeded 👏

Build Id: cf816f2b-368f-4a67-a262-9f27b5c3e3b8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-43e81ce
image: gcr.io/agones-images/agones-sdk:1.6.0-43e81ce
image: gcr.io/agones-images/agones-ping:1.6.0-43e81ce
Linux C++ SDK (build): agonessdk-1.6.0-43e81ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-43e81ce.zip

A preview of the website (the last 30 builds are retained):

https://43e81ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1479/head:pr_1479 && git checkout pr_1479
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-43e81ce

markmandel · 2020-04-23T23:39:20Z

/assign @cyriltovena

Can you review? I've no idea what any of this means 😄

cyriltovena · 2020-04-24T00:49:30Z

pkg/metrics/kubernetes_client.go

 	}))

 	runtime.Must(view.Register(&view.View{
 		Name:        "k8s_client_cache_list_items",
 		Measure:     cacheListItemCountStats,
 		Description: "Count of items in a list from the Kubernetes API.",
-		Aggregation: view.Distribution(0),
+		Aggregation: view.Distribution(0.00001),


I wonder why past me didn't put any buckets here ?

I think we should have 0,10,50,100,150,250,300.

cyriltovena · 2020-04-24T00:50:47Z

pkg/metrics/kubernetes_client.go

 	}))

 	runtime.Must(view.Register(&view.View{
 		Name:        "k8s_client_cache_watch_events",
 		Measure:     cacheItemsInWatchesCountStats,
 		Description: "Number of items in watches on the Kubernetes API.",
-		Aggregation: view.Distribution(0),
+		Aggregation: view.Distribution(0.00001),


Same here. you should use the same kind of buckets. It work for our dashboard to not have bucket cause I do average mostly but if you want 99th % you can't without proper buckets.

cyriltovena · 2020-04-24T00:51:09Z

Looks good just add bucket I forgot when I created this.

Zero value cannot be used as the only value for view.Distribution().

agones-bot · 2020-04-24T13:39:23Z

Build Succeeded 👏

Build Id: d4013f1b-826e-4d86-8946-6e5857c86f38

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-f592525
image: gcr.io/agones-images/agones-sdk:1.6.0-f592525
image: gcr.io/agones-images/agones-ping:1.6.0-f592525
Linux C++ SDK (build): agonessdk-1.6.0-f592525-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-f592525.zip

A preview of the website (the last 30 builds are retained):

https://f592525-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1479/head:pr_1479 && git checkout pr_1479
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-f592525

agones-bot · 2020-04-24T23:01:58Z

Build Succeeded 👏

Build Id: a01593b7-c13a-42d8-b033-c2018fb9ca62

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-8ebe417
image: gcr.io/agones-images/agones-sdk:1.6.0-8ebe417
image: gcr.io/agones-images/agones-ping:1.6.0-8ebe417
Linux C++ SDK (build): agonessdk-1.6.0-8ebe417-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-8ebe417.zip

A preview of the website (the last 30 builds are retained):

https://8ebe417-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1479/head:pr_1479 && git checkout pr_1479
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-8ebe417

cyriltovena

LGTM

google-oss-robot · 2020-04-25T00:31:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, cyriltovena

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cyriltovena]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Zero value cannot be used as the only value for view.Distribution().

google-oss-robot added the do-not-merge/work-in-progress label Apr 17, 2020

google-oss-robot requested review from EricFortin and roberthbailey April 17, 2020 14:24

google-oss-robot added the size/S label Apr 17, 2020

aLekSer mentioned this pull request Apr 22, 2020

Metrics: Export to Stackdriver is not working #1330

Closed

4 tasks

aLekSer mentioned this pull request Apr 23, 2020

Docs: add Grafana version explicitly #1487

Merged

aLekSer force-pushed the fix/stackdriver-distribution branch from df9fe2b to 43e81ce Compare April 23, 2020 11:16

aLekSer marked this pull request as ready for review April 23, 2020 11:16

google-oss-robot removed the do-not-merge/work-in-progress label Apr 23, 2020

google-oss-robot assigned cyriltovena Apr 23, 2020

cyriltovena reviewed Apr 24, 2020

View reviewed changes

Monitoring: fix error on Stackdriver exporter

f592525

Zero value cannot be used as the only value for view.Distribution().

aLekSer force-pushed the fix/stackdriver-distribution branch from 43e81ce to f592525 Compare April 24, 2020 13:21

Merge branch 'master' into fix/stackdriver-distribution

8ebe417

cyriltovena approved these changes Apr 25, 2020

View reviewed changes

google-oss-robot added the lgtm label Apr 25, 2020

google-oss-robot added the approved label Apr 25, 2020

markmandel added area/operations Installation, updating, metrics etc kind/bug These are bugs. labels Apr 25, 2020

markmandel merged commit e7b92d6 into googleforgames:master Apr 25, 2020

markmandel added this to the 1.6.0 milestone Apr 25, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Monitoring: fix error on Stackdriver exporter (googleforgames#1479)

5ed6d0b

Zero value cannot be used as the only value for view.Distribution().

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monitoring: fix error on Stackdriver exporter #1479

Monitoring: fix error on Stackdriver exporter #1479

aLekSer commented Apr 17, 2020 •

edited

Loading

aLekSer commented Apr 17, 2020 •

edited

Loading

agones-bot commented Apr 17, 2020

aLekSer commented Apr 22, 2020

agones-bot commented Apr 23, 2020

markmandel commented Apr 23, 2020

cyriltovena Apr 24, 2020

cyriltovena Apr 24, 2020

cyriltovena commented Apr 24, 2020

agones-bot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

cyriltovena left a comment

google-oss-robot commented Apr 25, 2020

Monitoring: fix error on Stackdriver exporter #1479

Monitoring: fix error on Stackdriver exporter #1479

Conversation

aLekSer commented Apr 17, 2020 • edited Loading

aLekSer commented Apr 17, 2020 • edited Loading

agones-bot commented Apr 17, 2020

aLekSer commented Apr 22, 2020

agones-bot commented Apr 23, 2020

markmandel commented Apr 23, 2020

cyriltovena Apr 24, 2020

Choose a reason for hiding this comment

cyriltovena Apr 24, 2020

Choose a reason for hiding this comment

cyriltovena commented Apr 24, 2020

agones-bot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

cyriltovena left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 25, 2020

aLekSer commented Apr 17, 2020 •

edited

Loading

aLekSer commented Apr 17, 2020 •

edited

Loading