-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testify package in gomod #1492
Conversation
Build Succeeded 👏 Build Id: 78714b40-4573-4538-8657-b5ff9aa7241d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use go 1.13.5 as in make shell. 34 Files is too many. I got 8:
git diff --name-only | wc -l
8
Thanks, deleting Prometheus testutil.go
seems to be my miss, when I updated opencensus to a new version and then test separately.
Build Succeeded 👏 Build Id: 0d71def0-d588-4adf-a48a-940f1b816c31 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this update locally. Same results.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akremsa, aLekSer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds new functionality provided by a recent version of testify
What type of PR is this?
What this PR does / Why we need it:
I need a new functionality provided by a recent version of testify, that is why I decided to perform this update.