Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testify package in gomod #1492

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Apr 24, 2020

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
I need a new functionality provided by a recent version of testify, that is why I decided to perform this update.

@akremsa akremsa changed the title Updated packages in gomod Update testify package in gomod Apr 24, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 78714b40-4573-4538-8657-b5ff9aa7241d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1492/head:pr_1492 && git checkout pr_1492
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3f884f0

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use go 1.13.5 as in make shell. 34 Files is too many. I got 8:

 git diff --name-only  | wc -l
       8

Thanks, deleting Prometheus testutil.go seems to be my miss, when I updated opencensus to a new version and then test separately.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0d71def0-d588-4adf-a48a-940f1b816c31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1492/head:pr_1492 && git checkout pr_1492
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-94c244e

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this update locally. Same results.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign dzlier-gcp
You can assign the PR to them by writing /assign @dzlier-gcp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 8b628c1 into googleforgames:master Apr 24, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Adds new functionality provided by a recent version of testify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants