Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to client SDK documentation #1500

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Fix link to client SDK documentation #1500

merged 2 commits into from
Apr 29, 2020

Conversation

ramonberrutti
Copy link
Contributor

Fix link typo.

What type of PR is this?
/kind documentation
/kind hotfix

markmandel
markmandel approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, ramonberrutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones and removed approved labels Apr 29, 2020
@markmandel markmandel added this to the 1.6.0 milestone Apr 29, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 11382a4f-1eb5-4327-872e-6aa694b62a21

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1500/head:pr_1500 && git checkout pr_1500
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-56619c8

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0a871e87-c842-4bb3-a21a-c316e2841a56

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1500/head:pr_1500 && git checkout pr_1500
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-1d1a25c

@markmandel markmandel merged commit f3ddd45 into googleforgames:master Apr 29, 2020
@ramonberrutti ramonberrutti deleted the fix/rust_client_sdk_link branch May 1, 2020 03:02
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@ramonberrutti @markmandel @ilkercelikyilmaz
Fix link to client SDK documentation (googleforgames#1500)
2bc9b0c 
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ramonberrutti @google-oss-robot @agones-bot @markmandel