Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to run individual e2e tests in Intellij #1506

Merged
merged 1 commit into from
May 1, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

/kind breaking

kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Had an issue with running a single e2e test within IntelliJ, because of
flag parsing.

Updating the pflag library, and making a small tweak to the framework
library seems to have done the trick.

Also included some more debugging logging on the state of the end to end test.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
None.

Had an issue with running a single e2e test within IntelliJ, because of
flag parsing.

Updating the pflag library, and making a small tweak to the framework
library seems to have done the trick.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels May 1, 2020
@markmandel markmandel requested a review from aLekSer May 1, 2020 04:26
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 39e2396c-0a64-45ea-b2c5-df12c5ac01e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1506/head:pr_1506 && git checkout pr_1506
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-7763bcd

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that a way was found to resolve an issue with IDE and pflag.

@aLekSer aLekSer merged commit 2e884c3 into googleforgames:master May 1, 2020
@markmandel markmandel deleted the bug/e2e-framework branch May 1, 2020 20:56
@markmandel markmandel added this to the 1.6.0 milestone May 1, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Had an issue with running a single e2e test within IntelliJ, because of
flag parsing.

Updating the pflag library, and making a small tweak to the framework
library seems to have done the trick.
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Had an issue with running a single e2e test within IntelliJ, because of
flag parsing.

Updating the pflag library, and making a small tweak to the framework
library seems to have done the trick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants