Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity SDK: Fix SpecHealth parsing #1510

Merged

Conversation

cadfoot
Copy link
Contributor

@cadfoot cadfoot commented May 2, 2020

What type of PR is this?

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Fix type cast error in Unity SDK when parsing SpecHealth

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

The issue occurs only when health check is disabled.
disabled value is already type of bool (boxed), thus casting it to string causes InvalidCastException

fixed Disabled value typecast
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cadfoot
Copy link
Contributor Author

cadfoot commented May 2, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: db680aa6-0af1-4229-a425-868b02d7ad4c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1510/head:pr_1510 && git checkout pr_1510
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-dafc008

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 04ce5720-d92d-4d8b-bb48-2183aa126a34

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1510/head:pr_1510 && git checkout pr_1510
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-fa2fd20

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Approved! 👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cadfoot, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 194294ab-3ea4-4424-8945-e473dfc4a8c8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1510/head:pr_1510 && git checkout pr_1510
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-204d870

@cadfoot
Copy link
Contributor Author

cadfoot commented May 4, 2020

just found out I messed up with the last commit and brought bad casting back, fixing this

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: afbfe1f8-3b9a-4fab-bb3a-ba66cf6106f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1510/head:pr_1510 && git checkout pr_1510
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-6e2c771

@markmandel markmandel merged commit 6724bd3 into googleforgames:master May 4, 2020
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels May 4, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 4, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* Fix Unity SDK SpecHealth parsing

* Skip parsing health check data if it is disabled
* Fix incorrect parsing

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants