-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity SDK: Fix SpecHealth parsing #1510
Unity SDK: Fix SpecHealth parsing #1510
Conversation
fixed Disabled value typecast
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Build Succeeded 👏 Build Id: db680aa6-0af1-4229-a425-868b02d7ad4c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 04ce5720-d92d-4d8b-bb48-2183aa126a34 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Approved! 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cadfoot, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 194294ab-3ea4-4424-8945-e473dfc4a8c8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
just found out I messed up with the last commit and brought bad casting back, fixing this |
Build Succeeded 👏 Build Id: afbfe1f8-3b9a-4fab-bb3a-ba66cf6106f8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
* Fix Unity SDK SpecHealth parsing * Skip parsing health check data if it is disabled * Fix incorrect parsing Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Fix type cast error in Unity SDK when parsing SpecHealth
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
The issue occurs only when health check is disabled.
disabled
value is already type ofbool
(boxed), thus casting it tostring
causesInvalidCastException