Fix allocator service tls auth for C# client and add a C# sample #1514
Conversation
|
Build Succeeded 👏 Build Id: 0e743eb0-c6c3-49c4-bfd6-00d69f0aa8b3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
area/user-experience
| @@ -0,0 +1,19 @@ | |||
| # A sample Allocator service C# client | |||
There was a problem hiding this comment.
Should we link this somewhere, such as here?
https://agones.dev/site/docs/advanced/allocator-service/#send-allocation-request
(and wrapped in a feature code block)
There was a problem hiding this comment.
Thanks for pointing it out.
PTAL. I added a note.
|
Build Failed 😱 Build Id: bf292a1a-1e34-4b66-8207-d0ce962cf7f5 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 96c551aa-dd87-44ba-8ef5-f33c80f1032d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -115,7 +115,8 @@ kubectl get pods -n agones-system -o=name | grep agones-allocator | xargs kubect | |||
|
|
|||
| ## Send allocation request | |||
|
|
|||
| Now the service is ready to accept requests from the client with the generated certificates. Create a [fleet](https://agones.dev/site/docs/getting-started/create-fleet/#1-create-a-fleet) and send a gRPC request to agones-allocator by providing the namespace to which the fleet is deployed. You can find the gRPC sample for sending allocation request at {{< ghlink href="examples/allocator-client/main.go" >}}allocator-client sample{{< /ghlink >}}. | |||
| Now the service is ready to accept requests from the client with the generated certificates. Create a [fleet](https://agones.dev/site/docs/getting-started/create-fleet/#1-create-a-fleet) and send a gRPC request to agones-allocator. To start, take a look at the allocation gRPC client examples in {{< ghlink href="examples/allocator-client/main.go" >}}golang{{< /ghlink >}} and {{< ghlink href="examples/allocator-client-csharp/Program.cs" >}}C#{{< /ghlink >}} languages. In the following, the {{< ghlink href="examples/allocator-client/main.go" >}}golang gRPC client example{{< /ghlink >}} is used to allocate a Game Server in the default namespace. | |||
There was a problem hiding this comment.
Do we want this to show up on the current documentation, or only after the next release?
If we want it after the next release, we should create publish and expire versions of this paragraph:
https://agones.dev/site/docs/contribute/#within-a-page
Other than that, this looks good to go 👍
There was a problem hiding this comment.
Thanks for the suggestion. Makes sense. I added the feature wrapper to expose the content with 1.6 release.
|
Build Succeeded 👏 Build Id: 86212cbe-221f-436d-b7dc-dbcd7684cb00 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: cfeedebd-a735-45c0-ab09-7abd087fd231 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
C# client cannot talk to agone-allocator service due to language incompatibility for handling mTLS. Changed the mTLS handling to custom verify client certificate.
Also, added C# client sample code that is compatible with the golang gRPC server.
Which issue(s) this PR fixes:
Closes #1421