Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fleetautoscalers - controller unit tests #1515

Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented May 6, 2020

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Added missing unit tests, refactored some old ones.

Special notes for your reviewer:
Before:
Screenshot 2020-05-06 at 14 30 27

After:
Screenshot 2020-05-06 at 14 31 24

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2bfaab00-efc9-466e-ba26-3b424bf8ad68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1515/head:pr_1515 && git checkout pr_1515
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-7e9e2e0

@aLekSer aLekSer added the area/tests Unit tests, e2e tests, anything to make sure things don't break label May 6, 2020
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit b5a2272 into googleforgames:master May 6, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 6, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants