Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in workerqueue #1525

Merged
merged 2 commits into from
May 8, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Fixes a typo in a comment

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a60ed4a1-b0cf-4b01-94e7-fd379e2d9ccd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1525/head:pr_1525 && git checkout pr_1525
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-fe97588

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EricFortin, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EricFortin,markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.6.0 milestone May 8, 2020
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee70f786-8ec1-4a9b-84f1-36c78598d40b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1525/head:pr_1525 && git checkout pr_1525
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-e1e552d

@markmandel markmandel merged commit 03a7e78 into googleforgames:master May 8, 2020
@markmandel markmandel deleted the cleanup/wq-spelling branch May 11, 2020 21:11
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants