Fix broken Fuzz Roundtrip tests in 1.15 #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for errors like: GameServerSet does not implement the protobuf marshalling interface. There exist a function RoundTripExternalTypesWithoutProtobuf() which do the same but it not available in 1.15.
|
Build Failed 😱 Build Id: 3ae3fe88-fd19-4ed1-87b3-6147891239ba To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 9eb41b86-ab2c-488a-8c2a-eabe677a18e5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
approved these changes
May 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markmandel
added
area/tests
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
Fix for errors like: GameServerSet does not implement the protobuf marshalling interface. There exist a function RoundTripExternalTypesWithoutProtobuf() which do the same but it not available in 1.15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for errors like:
GameServerSet does not implement the protobuf marshalling interface.
There exist a function RoundTripExternalTypesWithoutProtobuf() which do
the same but it not available in 1.15.
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Kubernetes version 1.15 enabled Protobuf codecs in Roundtrip tests. More details here.
This PR would return disable Protobuf checks as it was in 1.14.
#1478 (comment)
Which issue(s) this PR fixes:
For #1478
Special notes for your reviewer:
There could be some other ways to fix this. With this fix at lest we would not loose the tests which was prior to the update to 1.15.