Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client-go and related to 1.15 #1532

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

This upgrade client-go, apimachinery, apiextensions-apiserver and related to support Kubernetes 1.15, as well as regenerated clients for our CRDs.

Also included is a fix to gen-crd-client.sh such that it can now use Go modules, as otherwise it was failing to generate clients.

Which issue(s) this PR fixes:

Work on #1478

Special notes for your reviewer:

The only edited files that are probably worth looking at are Dockerfile, gen-crd-client.sh and go.mod.
Everything else is generated / vendoring.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2142dc6f-3237-4fe9-9ecf-dcd2a683e70f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x19faac0]

goroutine 1218 [running]:
testing.tRunner.func1(0xc0005d2100)
	/usr/local/go/src/testing/testing.go:874 +0x69f
panic(0x1bc19e0, 0x2b21820)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
agones.dev/agones/pkg/gameservers.(*Controller).createGameServerPod(0xc0003025a0, 0xc001187b00, 0x1d61b72, 0x8, 0xc000806000)
	/go/src/agones.dev/agones/pkg/gameservers/controller.go:596 +0x1220
agones.dev/agones/pkg/gameservers.(*Controller).syncGameServerCreatingState(0xc0003025a0, 0xc001187b00, 0xc0002bd130, 0xc0000ef080, 0xc0000eefd0)
	/go/src/agones.dev/agones/pkg/gameservers/controller.go:494 +0x5e9
agones.dev/agones/pkg/gameservers.TestControllerSyncGameServerCreatingState.func3(0xc0005d2100)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:675 +0x980
testing.tRunner(0xc0005d2100, 0xc0003d4fd0)
	/usr/local/go/src/testing/testing.go:909 +0x19a
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x652
FAIL	agones.dev/agones/pkg/gameservers	5.381s
ok  	agones.dev/agones/pkg/gameserversets	3.218s

Putting this here so it's easier to lookup, and find out what the culprit is when I dig into this.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dc31a90d-e431-4f87-b51c-442aa781759a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2149e122-18db-4434-9ddb-f902036b16d3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

go.mod Outdated
k8s.io/apiextensions-apiserver v0.0.0-20191212015246-8fe0c124fb40 // kubernetes-1.14.10
k8s.io/apimachinery v0.0.0-20191004074956-c5d2f014d689 // kubernetes-1.14.10
k8s.io/client-go v11.0.1-0.20191029005444-8e4128053008+incompatible // kubernetes-1.14.10
k8s.io/api v0.15.11 // kubernetes-1.14.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where these comments came from (did we add them by hand) but they are now out of date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.mod is generated by the go tooling. I've bo idea where they came from.

I'll edit them by hand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

This upgrade client-go, apimachinery, apiextensions-apiserver and
related to support Kubernetes 1.15, as well as regenerated clients for
our CRDs.

Also included is a fix to gen-crd-client.sh such that it can now use Go
modules, as otherwise it was failing to generate clients.

Work on googleforgames#1478
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 538a88c3-ba68-4203-a0ca-55ac0ca9078f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1532/head:pr_1532 && git checkout pr_1532
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-f3aa669

@roberthbailey roberthbailey merged commit 5df2a6c into googleforgames:master May 8, 2020
@markmandel markmandel deleted the feature/1.15-client branch May 8, 2020 23:15
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
This upgrade client-go, apimachinery, apiextensions-apiserver and
related to support Kubernetes 1.15, as well as regenerated clients for
our CRDs.

Also included is a fix to gen-crd-client.sh such that it can now use Go
modules, as otherwise it was failing to generate clients.

Work on googleforgames#1478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants