-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade client-go and related to 1.15 #1532
Upgrade client-go and related to 1.15 #1532
Conversation
Build Failed 😱 Build Id: 2142dc6f-3237-4fe9-9ecf-dcd2a683e70f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Putting this here so it's easier to lookup, and find out what the culprit is when I dig into this. |
Build Failed 😱 Build Id: dc31a90d-e431-4f87-b51c-442aa781759a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 2149e122-18db-4434-9ddb-f902036b16d3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
7079ea4
to
a4e277e
Compare
go.mod
Outdated
k8s.io/apiextensions-apiserver v0.0.0-20191212015246-8fe0c124fb40 // kubernetes-1.14.10 | ||
k8s.io/apimachinery v0.0.0-20191004074956-c5d2f014d689 // kubernetes-1.14.10 | ||
k8s.io/client-go v11.0.1-0.20191029005444-8e4128053008+incompatible // kubernetes-1.14.10 | ||
k8s.io/api v0.15.11 // kubernetes-1.14.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where these comments came from (did we add them by hand) but they are now out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.mod is generated by the go tooling. I've bo idea where they came from.
I'll edit them by hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
a4e277e
to
1b71574
Compare
This upgrade client-go, apimachinery, apiextensions-apiserver and related to support Kubernetes 1.15, as well as regenerated clients for our CRDs. Also included is a fix to gen-crd-client.sh such that it can now use Go modules, as otherwise it was failing to generate clients. Work on googleforgames#1478
1b71574
to
f3aa669
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 538a88c3-ba68-4203-a0ca-55ac0ca9078f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This upgrade client-go, apimachinery, apiextensions-apiserver and related to support Kubernetes 1.15, as well as regenerated clients for our CRDs. Also included is a fix to gen-crd-client.sh such that it can now use Go modules, as otherwise it was failing to generate clients. Work on googleforgames#1478
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This upgrade client-go, apimachinery, apiextensions-apiserver and related to support Kubernetes 1.15, as well as regenerated clients for our CRDs.
Also included is a fix to gen-crd-client.sh such that it can now use Go modules, as otherwise it was failing to generate clients.
Which issue(s) this PR fixes:
Work on #1478
Special notes for your reviewer:
The only edited files that are probably worth looking at are Dockerfile, gen-crd-client.sh and go.mod.
Everything else is generated / vendoring.