Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestControllerSyncGameServerCreatingState #1533

Merged
merged 2 commits into from
May 10, 2020
Merged

Flaky: TestControllerSyncGameServerCreatingState #1533

merged 2 commits into from
May 10, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Informer in the test should be syncing on Pods, not GameServers.

@markmandel
Flaky: TestControllerSyncGameServerCreatingState
e3a8fe1 
Informer in the test should be syncing on Pods,
not GameServers.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels May 8, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 87309520-4600-4257-ab92-f14b842875be

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1533/head:pr_1533 && git checkout pr_1533
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-e3a8fe1

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c3b85a08-65b5-43a5-9e6a-93116ba9b4a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1533/head:pr_1533 && git checkout pr_1533
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-f2c1438

@roberthbailey roberthbailey merged commit 047cf27 into googleforgames:master May 10, 2020
@markmandel markmandel deleted the flaky/TestControllerSyncGameServerCreatingState branch May 10, 2020 00:01
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @roberthbailey @ilkercelikyilmaz
Flaky: TestControllerSyncGameServerCreatingState (googleforgames#1533)
d580a1a 
Informer in the test should be syncing on Pods,
not GameServers.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey