-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Tracking Proto: Players => players #1560
Player Tracking Proto: Players => players #1560
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: 564d265a-f12a-4605-b7d6-e39efd1448d1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
05889fe
to
9da694a
Compare
New changes are detected. LGTM label has been removed. |
Fix this up so it also conforms to naming conventions. Work on googleforgames#1033
9da694a
to
02c05b0
Compare
Build Succeeded 👏 Build Id: de763ab0-90cf-4ea8-a644-059bba06ee66 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 26738606-ea20-4f89-bbc5-5cc3eaaa3868 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 09c86c15-8cf0-40dc-897c-7aed5810d40a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: a7941848-b30e-4467-958a-74f70a8a7f04 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: bf1c2571-500b-47a3-92fc-1f750e21daf0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Fix this up so it also conforms to naming conventions. Work on googleforgames#1033
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Fix this up so it also conforms to naming conventions.
Which issue(s) this PR fixes:
Work on #1033
Special notes for your reviewer:
None