Flaky: TestGameServerReserve #1565
Conversation
markmandel
added
kind/bug
|
Build Failed 😱 Build Id: 82f1d240-d5ec-4b72-b25e-3d5787daf7aa To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
force-pushed
the
flaky/TestGameServerReserve-5
branch
from
3aed700
to
de6b01e
Compare
|
Build Failed 😱 Build Id: 2d8d2e20-6781-48c3-be24-1a488cffe7ec To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
force-pushed
the
flaky/TestGameServerReserve-5
branch
2 times, most recently
from
1926502
to
2dd1475
Compare
|
Image has been pushed up. This was making me climb up the walls with frustration. Feels like it's failing on just about every run. |
examples/simple-udp/main.go
Outdated
| @@ -144,7 +145,17 @@ func readWriteLoop(conn net.PacketConn, stop chan struct{}, s *sdk.SDK) { | |||
| allocate(s) | |||
|
|
|||
| case "RESERVE": | |||
| reserve(s) | |||
| if len(parts) == 2 { | |||
There was a problem hiding this comment.
Sorry I didn't catch this last time, but it would be a bit more idiomatic to do:
if len(parts) != 2 {
respond()
continue
}
if dur, err := ... ; err != nil {
respond()
continue
}
reserve(s, dur)
so that the non-error flow isn't indented quite so much.
There was a problem hiding this comment.
Ah that is nicer. I'll make that change.
markmandel
force-pushed
the
flaky/TestGameServerReserve-5
branch
from
2dd1475
to
870bf21
Compare
|
Build Failed 😱 Build Id: 47517cbe-d137-4c2b-bbea-da1605ac7667 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: bb256476-006c-47de-b0b2-7d79788682d3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Would help if I actually pushed the right image. |
|
Build Failed 😱 Build Id: ebf7437c-4978-4c96-9efb-0d69d2176a14 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Trying to test transitive state while it is actively changing is fraught with peril. Tests flake, hair is pulled, and screams echo throughout the lands. This PR allows one to send a duration to the RESERVE command to udp-simple, as well as update TestGameServerReserve to only confirm concrete states, which therefore can't flake. Closes googleforgames#1543
Included instructions on how to update.
markmandel
force-pushed
the
flaky/TestGameServerReserve-5
branch
from
870bf21
to
cf3d23f
Compare
| @@ -456,72 +456,81 @@ func TestAutoscalerWebhook(t *testing.T) { | |||
| assert.True(t, found, "Expected error was not received") | |||
| } | |||
|
|
|||
| // Instructions: https://agones.dev/site/docs/getting-started/create-webhook-fleetautoscaler/#chapter-2-configuring-https-fleetautoscaler-webhook-with-ca-bundle | |||
There was a problem hiding this comment.
fyi @aLekSer , I updated the certs here, and added a comment on how to update and when expiry should happen.
|
Build Succeeded 👏 Build Id: d5d5d152-9e8b-4c10-96c5-ce139bc7fc82 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Flaky: TestGameServerReserve Trying to test transitive state while it is actively changing is fraught with peril. Tests flake, hair is pulled, and screams echo throughout the lands. This PR allows one to send a duration to the RESERVE command to udp-simple, as well as update TestGameServerReserve to only confirm concrete states, which therefore can't flake. Closes googleforgames#1543 * Updated certs for TestTlsWebhook Included instructions on how to update.
* Flaky: TestGameServerReserve Trying to test transitive state while it is actively changing is fraught with peril. Tests flake, hair is pulled, and screams echo throughout the lands. This PR allows one to send a duration to the RESERVE command to udp-simple, as well as update TestGameServerReserve to only confirm concrete states, which therefore can't flake. Closes googleforgames#1543 * Updated certs for TestTlsWebhook Included instructions on how to update.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Trying to test transitive state while it is actively changing is fraught with peril. Tests flake, hair is pulled, and screams echo throughout the lands.
This PR allows one to send a duration to the RESERVE command to udp-simple, as well as update TestGameServerReserve to only confirm concrete states, which therefore can't flake.
Which issue(s) this PR fixes:
Closes #1543
Special notes for your reviewer:
Tests will fail, as image does not yet exist. Once initial reviews are complete, I'll push up the new udp-simple image.