Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo sercerCA -> serverCa #1567

Merged
merged 2 commits into from
May 18, 2020
Merged

Fixed a typo sercerCA -> serverCa #1567

merged 2 commits into from
May 18, 2020

Conversation

pooneh-m
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Fixes a typo.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 053c1c73-f4d1-4a6b-aab9-fb5851daf13b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9cd7694e-0979-4aaa-b75d-1123472e77ac

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fddce3c2-2fd4-43db-928b-6d08b2cd3a0f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 31492896-fefe-41a8-9e5e-c33597274096

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 16f738bb-5306-4f0e-98e6-a822d63d8d29

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 18dc0345-f331-484f-b7f2-a19f6e98ba11

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 685ef4d3-8d4e-47db-8792-768df09041ce

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1567/head:pr_1567 && git checkout pr_1567
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-728c31f

@markmandel markmandel merged commit d2639bf into master May 18, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 18, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels May 18, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @markmandel @ilkercelikyilmaz
Fixed a typo sercerCA -> serverCa (googleforgames#1567)
f0dd9e7 
Co-authored-by: Mark Mandel <markmandel@google.com>
@markmandel markmandel deleted the pooneh-m-patch-1 branch December 11, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pooneh-m @agones-bot @google-oss-robot @markmandel @roberthbailey