Move ContainerPortAllocation to beta #1577

akremsa · 2020-05-20T12:54:08Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:
Move ContainerPortAllocation to beta

Which issue(s) this PR fixes:
Closes #1563

Special notes for your reviewer:
Two tables with features are not visible here:
https://agones.dev/site/docs/guides/feature-stages/

Checked with Chrome and Safari.
But they are visible if I build the site locally.

agones-bot · 2020-05-20T13:12:01Z

Build Succeeded 👏

Build Id: aa561f25-8294-4c05-94d2-c5e4cb0bcf79

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-d54f0d5
image: gcr.io/agones-images/agones-sdk:1.6.0-d54f0d5
image: gcr.io/agones-images/agones-ping:1.6.0-d54f0d5
Linux C++ SDK (build): agonessdk-1.6.0-d54f0d5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-d54f0d5.zip

A preview of the website (the last 30 builds are retained):

https://d54f0d5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-d54f0d5

aLekSer · 2020-05-20T13:56:16Z

site/content/en/docs/Guides/feature-stages.md

@@ -29,15 +29,15 @@ The current set of `alpha` and `beta` feature gates are:
 |--------------|---------|---------|-------|-------|
 | Multicluster Allocation<sup>*</sup> | N/A | Enabled | `Alpha` | 0.11.0 |
 | Example Gate (not in use) | `Example` | Disabled | None | 0.13.0 |
-| [Port Allocations to Multiple Containers]({{< ref "/docs/Reference/gameserver.md" >}}) | `ContainerPortAllocation` | Disabled | `Alpha` | 1.5.0 |
+| [Port Allocations to Multiple Containers]({{< ref "/docs/Reference/gameserver.md" >}}) | `ContainerPortAllocation` | Enabled | `Beta` | 1.7.0 |
 {{% /feature %}}

 {{% feature publishVersion="1.6.0" %}}


Here should be a new version, but let's wait until the release.

Suggested change

{{% feature publishVersion="1.6.0" %}}

{{% feature publishVersion="1.7.0" %}}

roberthbailey · 2020-05-20T16:08:03Z

This should be held until after the 1.6 release since it missed the RC.

markmandel · 2020-05-20T17:32:41Z

Two tables with features are not visible here:
https://agones.dev/site/docs/guides/feature-stages/

Fixed!

agones-bot · 2020-05-22T12:45:59Z

Build Succeeded 👏

Build Id: 01c3a9c4-0fa7-4b2c-a58c-d92b51b531d9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-b613502
image: gcr.io/agones-images/agones-sdk:1.6.0-b613502
image: gcr.io/agones-images/agones-ping:1.6.0-b613502
Linux C++ SDK (build): agonessdk-1.6.0-b613502-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-b613502.zip

A preview of the website (the last 30 builds are retained):

https://b613502-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-b613502

agones-bot · 2020-05-27T14:15:23Z

Build Succeeded 👏

Build Id: 3c6fa636-40bb-41e8-800e-1694868b152a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-12f48bf
image: gcr.io/agones-images/agones-sdk:1.6.0-12f48bf
image: gcr.io/agones-images/agones-ping:1.6.0-12f48bf
Linux C++ SDK (build): agonessdk-1.6.0-12f48bf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-12f48bf.zip

A preview of the website (the last 30 builds are retained):

https://12f48bf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-12f48bf

agones-bot · 2020-05-27T14:20:06Z

Build Failed 😱

Build Id: 196abec0-f565-4d23-8eeb-0ecdcec23314

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

One small thing, but outside of that, this looks good 👍

build/includes/terraform.mk

agones-bot · 2020-05-27T23:23:07Z

Build Succeeded 👏

Build Id: 3d5add6f-ead9-4340-8185-d18810952f0f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-51f5f10
image: gcr.io/agones-images/agones-sdk:1.6.0-51f5f10
image: gcr.io/agones-images/agones-ping:1.6.0-51f5f10
Linux C++ SDK (build): agonessdk-1.6.0-51f5f10-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-51f5f10.zip

A preview of the website (the last 30 builds are retained):

https://51f5f10-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-51f5f10

markmandel · 2020-05-27T23:38:55Z

Should ContainerPortAllocation be removed from here as well?

agones/build/Makefile

Line 62 in 51f5f10

ALL_FEATURE_GATES ?= "PlayerTracking=true&ContainerPortAllocation=true"

(Maybe this should only be Alpha features, and be renamed?)

Otherwise, how do we know if a beta feature is going to stay on by default?

akremsa · 2020-05-27T23:43:30Z

Good suggestion. Updated Makefile.

agones-bot · 2020-05-27T23:45:26Z

Build Failed 😱

Build Id: 6b7a06c9-5d24-4a80-8285-40551ee86e6b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-05-28T00:04:38Z

Build Succeeded 👏

Build Id: c98ce74a-119f-45bc-8007-96b7ee1908c8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-3c5d772
image: gcr.io/agones-images/agones-sdk:1.6.0-3c5d772
image: gcr.io/agones-images/agones-ping:1.6.0-3c5d772
Linux C++ SDK (build): agonessdk-1.6.0-3c5d772-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-3c5d772.zip

A preview of the website (the last 30 builds are retained):

https://3c5d772-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3c5d772

markmandel · 2020-05-30T00:42:08Z

Found a couple more spots:
https://github.com/googleforgames/agones/blob/master/examples/gameserver.yaml#L45
https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Reference/gameserver.md

(Should probably move this to the Stage/FeatueFlag syntax we use below)

I think that's the last bit though!

agones-bot · 2020-06-01T11:23:29Z

Build Failed 😱

Build Id: ed2ff499-2fac-4889-bb3d-61b38200cd02

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-03T16:59:16Z

Build Failed 😱

Build Id: fa1426c6-ab0d-4d28-879e-a13633cabc70

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-06-03T17:06:08Z

Heh, going to need to run make gen-api-docs 😄

markmandel

🙌

added comments

leave only alpha features in makefile

fix

agones-bot · 2020-06-03T22:37:19Z

Build Succeeded 👏

Build Id: 79c486e4-d1f1-4ac4-b136-8bebecc18a9d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-c47ba5f
image: gcr.io/agones-images/agones-sdk:1.7.0-c47ba5f
image: gcr.io/agones-images/agones-ping:1.7.0-c47ba5f
Linux C++ SDK (build): agonessdk-1.7.0-c47ba5f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-c47ba5f.zip

A preview of the website (the last 30 builds are retained):

https://c47ba5f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1577/head:pr_1577 && git checkout pr_1577
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c47ba5f

markmandel · 2020-06-03T22:42:04Z

@aLekSer waiting on your approval! 😃 Can't merge since you requested changes.

aLekSer

Fine with me, I will update make gcloud-terraform-install in a separate PR to be in sync with make install.

google-oss-robot · 2020-06-04T07:00:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* site doc update * enable FeatureContainerPortAllocation added comments * conflict fix * applied review note leave only alpha features in makefile * review notes * regenerated site html * Updated features-stages.md fix * updated agones html Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from markmandel and roberthbailey May 20, 2020 12:54

google-oss-robot added the size/S label May 20, 2020

aLekSer reviewed May 20, 2020

View reviewed changes

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label May 20, 2020

akremsa force-pushed the ContainerPortAllocation-beta branch from d54f0d5 to b613502 Compare May 22, 2020 12:28

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label May 26, 2020

akremsa force-pushed the ContainerPortAllocation-beta branch from 12f48bf to cdffa2f Compare May 27, 2020 13:59

google-oss-robot added size/XS and removed size/S labels May 27, 2020

markmandel reviewed May 27, 2020

View reviewed changes

build/includes/terraform.mk Outdated Show resolved Hide resolved

akremsa force-pushed the ContainerPortAllocation-beta branch from cdffa2f to 51f5f10 Compare May 27, 2020 23:04

akremsa force-pushed the ContainerPortAllocation-beta branch from 51f5f10 to 59f486f Compare May 27, 2020 23:42

google-oss-robot added size/S and removed size/XS labels May 27, 2020

akremsa force-pushed the ContainerPortAllocation-beta branch from 59f486f to 3c5d772 Compare May 27, 2020 23:47

akremsa force-pushed the ContainerPortAllocation-beta branch from 40eca70 to 2d2e9dd Compare June 1, 2020 11:12

google-oss-robot assigned aLekSer Jun 3, 2020

akremsa force-pushed the ContainerPortAllocation-beta branch from 2b24c44 to b3e1d5d Compare June 3, 2020 16:43

akremsa force-pushed the ContainerPortAllocation-beta branch from 647493d to ae4dba0 Compare June 3, 2020 21:03

markmandel approved these changes Jun 3, 2020

View reviewed changes

google-oss-robot assigned markmandel Jun 3, 2020

google-oss-robot added lgtm approved labels Jun 3, 2020

alexey-kremsa-globant added 8 commits June 4, 2020 01:01

site doc update

7cbb9cb

enable FeatureContainerPortAllocation

331d1c7

added comments

conflict fix

779526e

applied review note

9ca7db2

leave only alpha features in makefile

review notes

8f02860

regenerated site html

66cbd0b

Updated features-stages.md

3441622

fix

updated agones html

4f3a83e

akremsa force-pushed the ContainerPortAllocation-beta branch from ae4dba0 to 4f3a83e Compare June 3, 2020 22:01

google-oss-robot removed the lgtm label Jun 3, 2020

Merge branch 'master' into ContainerPortAllocation-beta

c47ba5f

aLekSer approved these changes Jun 4, 2020

View reviewed changes

google-oss-robot added the lgtm label Jun 4, 2020

aLekSer merged commit 16ce6ce into googleforgames:master Jun 4, 2020

markmandel added this to the 1.7.0 milestone Jun 30, 2020

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jun 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move ContainerPortAllocation to beta #1577

Move ContainerPortAllocation to beta #1577

akremsa commented May 20, 2020 •

edited

Loading

agones-bot commented May 20, 2020

aLekSer May 20, 2020

roberthbailey commented May 20, 2020

markmandel commented May 20, 2020

agones-bot commented May 22, 2020

agones-bot commented May 27, 2020

agones-bot commented May 27, 2020

markmandel left a comment

agones-bot commented May 27, 2020

markmandel commented May 27, 2020 •

edited

Loading

akremsa commented May 27, 2020

agones-bot commented May 27, 2020

agones-bot commented May 28, 2020

markmandel commented May 30, 2020

agones-bot commented Jun 1, 2020

agones-bot commented Jun 3, 2020

markmandel commented Jun 3, 2020

markmandel left a comment

agones-bot commented Jun 3, 2020

markmandel commented Jun 3, 2020

aLekSer left a comment

google-oss-robot commented Jun 4, 2020

	{{% feature publishVersion="1.6.0" %}}
	{{% feature publishVersion="1.7.0" %}}

Move ContainerPortAllocation to beta #1577

Move ContainerPortAllocation to beta #1577

Conversation

akremsa commented May 20, 2020 • edited Loading

agones-bot commented May 20, 2020

aLekSer May 20, 2020

Choose a reason for hiding this comment

roberthbailey commented May 20, 2020

markmandel commented May 20, 2020

agones-bot commented May 22, 2020

agones-bot commented May 27, 2020

agones-bot commented May 27, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented May 27, 2020

markmandel commented May 27, 2020 • edited Loading

akremsa commented May 27, 2020

agones-bot commented May 27, 2020

agones-bot commented May 28, 2020

markmandel commented May 30, 2020

agones-bot commented Jun 1, 2020

agones-bot commented Jun 3, 2020

markmandel commented Jun 3, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jun 3, 2020

markmandel commented Jun 3, 2020

aLekSer left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jun 4, 2020

akremsa commented May 20, 2020 •

edited

Loading

markmandel commented May 27, 2020 •

edited

Loading