Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant "helm test" pod from "install.yaml" #1591

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Remove redundant "helm test" pod from "install.yaml" #1591

merged 2 commits into from
Jun 9, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 28, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Helm test template would create an additional pod in an error state.
Add new Helm variable to avoid creating new pod.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Thanks to Davit Mkrtchyan for pointing on this issue.

@aLekSer aLekSer added the area/operations Installation, updating, metrics etc label May 28, 2020
@aLekSer aLekSer changed the title Remove redundant helm test for install.yaml Remove redundant helm test pod in install.yaml May 28, 2020
@aLekSer aLekSer changed the title Remove redundant helm test pod in install.yaml Remove redundant "helm test" pod from "install.yaml" May 28, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec631017-80b1-40e8-831c-b5a573b44d16

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1591/head:pr_1591 && git checkout pr_1591
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3887d1e

markmandel
markmandel reviewed May 28, 2020
View reviewed changes
install/helm/agones/values.yaml
gameservers:
namespaces:
- default
minPort: 7000
maxPort: 8000

helm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - should this be on by default? Or should it be off?

I would have thought "off" would be better? Or no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this PR lacks of changes to helm.md. There is a statement about use helm test agones --cleanup as a simple test of your installation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but should we be installing this test pod by default on production deployments by default?

This seems to me like this is something people should opt into, rather than opt out. I didn't realise that the helm test would be installing a test pod on each cluster -- or maybe I'm missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for making it false by default, to match what this is changing in install.yaml.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I have updated this PR and subj.

@aLekSer aLekSer force-pushed the fix/install-yaml branch 2 times, most recently from eab1756 to 9043a13 Compare June 5, 2020 15:20
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ade1dad6-dbab-4c1b-8de0-f22af9a85764

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Remove redundant helm test for install.yaml
b54d7bb 
Helm test template would create an additional pod in an error state. Add
new Helm variable to avoid creating new pod.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4dc68644-028f-44e1-85be-527784decbe0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1591/head:pr_1591 && git checkout pr_1591
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-b54d7bb

markmandel
markmandel approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 8a45c47 into googleforgames:master Jun 9, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
Remove redundant helm test for install.yaml (googleforgames#1591)
b122f45 
Helm test template would create an additional pod in an error state. Add
new Helm variable to avoid creating new pod.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @markmandel @roberthbailey